summaryrefslogtreecommitdiff
path: root/sys/dev/raidframe/rf_dagfuncs.c
diff options
context:
space:
mode:
authorNiklas Hallqvist <niklas@cvs.openbsd.org>1999-02-16 00:03:34 +0000
committerNiklas Hallqvist <niklas@cvs.openbsd.org>1999-02-16 00:03:34 +0000
commit086450a69044f3ede65845d9a616116db9a6d006 (patch)
treea91a7d8f967737b7eed23cb127849d08e3af4d63 /sys/dev/raidframe/rf_dagfuncs.c
parent41fb84abc5659cc1a368cd59d7929ddf756c3297 (diff)
Merge from NetBSD, mostly indentation
Diffstat (limited to 'sys/dev/raidframe/rf_dagfuncs.c')
-rw-r--r--sys/dev/raidframe/rf_dagfuncs.c1469
1 files changed, 704 insertions, 765 deletions
diff --git a/sys/dev/raidframe/rf_dagfuncs.c b/sys/dev/raidframe/rf_dagfuncs.c
index 78e23ed1d95..a4ea944ba05 100644
--- a/sys/dev/raidframe/rf_dagfuncs.c
+++ b/sys/dev/raidframe/rf_dagfuncs.c
@@ -1,5 +1,5 @@
-/* $OpenBSD: rf_dagfuncs.c,v 1.1 1999/01/11 14:29:10 niklas Exp $ */
-/* $NetBSD: rf_dagfuncs.c,v 1.1 1998/11/13 04:20:28 oster Exp $ */
+/* $OpenBSD: rf_dagfuncs.c,v 1.2 1999/02/16 00:02:32 niklas Exp $ */
+/* $NetBSD: rf_dagfuncs.c,v 1.3 1999/02/05 00:06:08 oster Exp $ */
/*
* Copyright (c) 1995 Carnegie-Mellon University.
* All rights reserved.
@@ -48,172 +48,6 @@
* to check to find out whether or not the acquire was suppressed.
*/
-/* :
- * Log: rf_dagfuncs.c,v
- * Revision 1.64 1996/07/31 16:29:26 jimz
- * LONGSHIFT -> RF_LONGSHIFT, defined in rf_types.h
- *
- * Revision 1.63 1996/07/30 04:00:20 jimz
- * define LONGSHIFT for mips
- *
- * Revision 1.62 1996/07/28 20:31:39 jimz
- * i386netbsd port
- * true/false fixup
- *
- * Revision 1.61 1996/07/27 23:36:08 jimz
- * Solaris port of simulator
- *
- * Revision 1.60 1996/07/22 19:52:16 jimz
- * switched node params to RF_DagParam_t, a union of
- * a 64-bit int and a void *, for better portability
- * attempted hpux port, but failed partway through for
- * lack of a single C compiler capable of compiling all
- * source files
- *
- * Revision 1.59 1996/07/18 22:57:14 jimz
- * port simulator to AIX
- *
- * Revision 1.58 1996/07/17 21:00:58 jimz
- * clean up timer interface, tracing
- *
- * Revision 1.57 1996/07/15 17:22:18 jimz
- * nit-pick code cleanup
- * resolve stdlib problems on DEC OSF
- *
- * Revision 1.56 1996/06/11 01:27:50 jimz
- * Fixed bug where diskthread shutdown would crash or hang. This
- * turned out to be two distinct bugs:
- * (1) [crash] The thread shutdown code wasn't properly waiting for
- * all the diskthreads to complete. This caused diskthreads that were
- * exiting+cleaning up to unlock a destroyed mutex.
- * (2) [hang] TerminateDiskQueues wasn't locking, and DiskIODequeue
- * only checked for termination _after_ a wakeup if the queues were
- * empty. This was a race where the termination wakeup could be lost
- * by the dequeueing thread, and the system would hang waiting for the
- * thread to exit, while the thread waited for an I/O or a signal to
- * check the termination flag.
- *
- * Revision 1.55 1996/06/10 22:23:18 wvcii
- * disk and xor funcs now optionally support undo logging
- * for backward error recovery experiments
- *
- * Revision 1.54 1996/06/10 11:55:47 jimz
- * Straightened out some per-array/not-per-array distinctions, fixed
- * a couple bugs related to confusion. Added shutdown lists. Removed
- * layout shutdown function (now subsumed by shutdown lists).
- *
- * Revision 1.53 1996/06/07 21:33:04 jimz
- * begin using consistent types for sector numbers,
- * stripe numbers, row+col numbers, recon unit numbers
- *
- * Revision 1.52 1996/06/06 17:28:44 jimz
- * add new read mirror partition func, rename old read mirror
- * to rf_DiskReadMirrorIdleFunc
- *
- * Revision 1.51 1996/06/03 23:28:26 jimz
- * more bugfixes
- * check in tree to sync for IPDS runs with current bugfixes
- * there still may be a problem with threads in the script test
- * getting I/Os stuck- not trivially reproducible (runs ~50 times
- * in a row without getting stuck)
- *
- * Revision 1.50 1996/06/02 17:31:48 jimz
- * Moved a lot of global stuff into array structure, where it belongs.
- * Fixed up paritylogging, pss modules in this manner. Some general
- * code cleanup. Removed lots of dead code, some dead files.
- *
- * Revision 1.49 1996/05/31 22:26:54 jimz
- * fix a lot of mapping problems, memory allocation problems
- * found some weird lock issues, fixed 'em
- * more code cleanup
- *
- * Revision 1.48 1996/05/30 12:59:18 jimz
- * make etimer happier, more portable
- *
- * Revision 1.47 1996/05/30 11:29:41 jimz
- * Numerous bug fixes. Stripe lock release code disagreed with the taking code
- * about when stripes should be locked (I made it consistent: no parity, no lock)
- * There was a lot of extra serialization of I/Os which I've removed- a lot of
- * it was to calculate values for the cache code, which is no longer with us.
- * More types, function, macro cleanup. Added code to properly quiesce the array
- * on shutdown. Made a lot of stuff array-specific which was (bogusly) general
- * before. Fixed memory allocation, freeing bugs.
- *
- * Revision 1.46 1996/05/24 22:17:04 jimz
- * continue code + namespace cleanup
- * typed a bunch of flags
- *
- * Revision 1.45 1996/05/24 04:28:55 jimz
- * release cleanup ckpt
- *
- * Revision 1.44 1996/05/23 21:46:35 jimz
- * checkpoint in code cleanup (release prep)
- * lots of types, function names have been fixed
- *
- * Revision 1.43 1996/05/23 00:33:23 jimz
- * code cleanup: move all debug decls to rf_options.c, all extern
- * debug decls to rf_options.h, all debug vars preceded by rf_
- *
- * Revision 1.42 1996/05/18 19:51:34 jimz
- * major code cleanup- fix syntax, make some types consistent,
- * add prototypes, clean out dead code, et cetera
- *
- * Revision 1.41 1996/05/08 21:01:24 jimz
- * fixed up enum type names that were conflicting with other
- * enums and function names (ie, "panic")
- * future naming trends will be towards RF_ and rf_ for
- * everything raidframe-related
- *
- * Revision 1.40 1996/05/08 15:24:14 wvcii
- * modified GenericWakeupFunc to use recover, undone, and panic node states
- *
- * Revision 1.39 1996/05/02 17:18:01 jimz
- * fix up headers for user-land, following ccmn cleanup
- *
- * Revision 1.38 1996/05/01 16:26:51 jimz
- * don't include rf_ccmn.h (get ready to phase out)
- *
- * Revision 1.37 1995/12/12 18:10:06 jimz
- * MIN -> RF_MIN, MAX -> RF_MAX, ASSERT -> RF_ASSERT
- * fix 80-column brain damage in comments
- *
- * Revision 1.36 1995/12/04 19:19:09 wvcii
- * modified DiskReadMirrorFunc
- * - added fifth parameter, physical disk address of mirror copy
- * - SelectIdleDisk conditionally swaps parameters 0 & 4
- *
- * Revision 1.35 1995/12/01 15:58:33 root
- * added copyright info
- *
- * Revision 1.34 1995/11/17 18:12:17 amiri
- * Changed DiskReadMirrorFunc to use the generic mapping routines
- * to find the mirror of the data, function was assuming RAID level 1.
- *
- * Revision 1.33 1995/11/17 15:15:59 wvcii
- * changes in DiskReadMirrorFunc
- * - added ASSERTs
- * - added call to MapParityRAID1
- *
- * Revision 1.32 1995/11/07 16:25:50 wvcii
- * added DiskUnlockFuncForThreads
- * general debugging of undo functions (first time they were used)
- *
- * Revision 1.31 1995/09/06 19:23:36 wvcii
- * fixed tracing for parity logging nodes
- *
- * Revision 1.30 95/07/07 00:13:01 wvcii
- * added 4th parameter to ParityLogAppend
- *
- */
-
-#ifdef _KERNEL
-#define KERNEL
-#endif
-
-#ifndef KERNEL
-#include <errno.h>
-#endif /* !KERNEL */
-
#include <sys/ioctl.h>
#include <sys/param.h>
@@ -229,41 +63,40 @@
#include "rf_engine.h"
#include "rf_dagutils.h"
-#ifdef KERNEL
#include "rf_kintf.h"
-#endif /* KERNEL */
#if RF_INCLUDE_PARITYLOGGING > 0
#include "rf_paritylog.h"
-#endif /* RF_INCLUDE_PARITYLOGGING > 0 */
-
-int (*rf_DiskReadFunc)(RF_DagNode_t *);
-int (*rf_DiskWriteFunc)(RF_DagNode_t *);
-int (*rf_DiskReadUndoFunc)(RF_DagNode_t *);
-int (*rf_DiskWriteUndoFunc)(RF_DagNode_t *);
-int (*rf_DiskUnlockFunc)(RF_DagNode_t *);
-int (*rf_DiskUnlockUndoFunc)(RF_DagNode_t *);
-int (*rf_RegularXorUndoFunc)(RF_DagNode_t *);
-int (*rf_SimpleXorUndoFunc)(RF_DagNode_t *);
-int (*rf_RecoveryXorUndoFunc)(RF_DagNode_t *);
+#endif /* RF_INCLUDE_PARITYLOGGING > 0 */
+
+int (*rf_DiskReadFunc) (RF_DagNode_t *);
+int (*rf_DiskWriteFunc) (RF_DagNode_t *);
+int (*rf_DiskReadUndoFunc) (RF_DagNode_t *);
+int (*rf_DiskWriteUndoFunc) (RF_DagNode_t *);
+int (*rf_DiskUnlockFunc) (RF_DagNode_t *);
+int (*rf_DiskUnlockUndoFunc) (RF_DagNode_t *);
+int (*rf_RegularXorUndoFunc) (RF_DagNode_t *);
+int (*rf_SimpleXorUndoFunc) (RF_DagNode_t *);
+int (*rf_RecoveryXorUndoFunc) (RF_DagNode_t *);
/*****************************************************************************************
* main (only) configuration routine for this module
****************************************************************************************/
-int rf_ConfigureDAGFuncs(listp)
- RF_ShutdownList_t **listp;
+int
+rf_ConfigureDAGFuncs(listp)
+ RF_ShutdownList_t **listp;
{
- RF_ASSERT( ((sizeof(long)==8) && RF_LONGSHIFT==3) || ((sizeof(long)==4) && RF_LONGSHIFT==2) );
- rf_DiskReadFunc = rf_DiskReadFuncForThreads;
- rf_DiskReadUndoFunc = rf_DiskUndoFunc;
- rf_DiskWriteFunc = rf_DiskWriteFuncForThreads;
- rf_DiskWriteUndoFunc = rf_DiskUndoFunc;
- rf_DiskUnlockFunc = rf_DiskUnlockFuncForThreads;
- rf_DiskUnlockUndoFunc = rf_NullNodeUndoFunc;
- rf_RegularXorUndoFunc = rf_NullNodeUndoFunc;
- rf_SimpleXorUndoFunc = rf_NullNodeUndoFunc;
- rf_RecoveryXorUndoFunc = rf_NullNodeUndoFunc;
- return(0);
+ RF_ASSERT(((sizeof(long) == 8) && RF_LONGSHIFT == 3) || ((sizeof(long) == 4) && RF_LONGSHIFT == 2));
+ rf_DiskReadFunc = rf_DiskReadFuncForThreads;
+ rf_DiskReadUndoFunc = rf_DiskUndoFunc;
+ rf_DiskWriteFunc = rf_DiskWriteFuncForThreads;
+ rf_DiskWriteUndoFunc = rf_DiskUndoFunc;
+ rf_DiskUnlockFunc = rf_DiskUnlockFuncForThreads;
+ rf_DiskUnlockUndoFunc = rf_NullNodeUndoFunc;
+ rf_RegularXorUndoFunc = rf_NullNodeUndoFunc;
+ rf_SimpleXorUndoFunc = rf_NullNodeUndoFunc;
+ rf_RecoveryXorUndoFunc = rf_NullNodeUndoFunc;
+ return (0);
}
@@ -271,18 +104,20 @@ int rf_ConfigureDAGFuncs(listp)
/*****************************************************************************************
* the execution function associated with a terminate node
****************************************************************************************/
-int rf_TerminateFunc(node)
- RF_DagNode_t *node;
+int
+rf_TerminateFunc(node)
+ RF_DagNode_t *node;
{
- RF_ASSERT(node->dagHdr->numCommits == node->dagHdr->numCommitNodes);
- node->status = rf_good;
- return(rf_FinishNode(node, RF_THREAD_CONTEXT));
+ RF_ASSERT(node->dagHdr->numCommits == node->dagHdr->numCommitNodes);
+ node->status = rf_good;
+ return (rf_FinishNode(node, RF_THREAD_CONTEXT));
}
-int rf_TerminateUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_TerminateUndoFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
@@ -299,30 +134,33 @@ int rf_TerminateUndoFunc(node)
*
****************************************************************************************/
-int rf_DiskReadMirrorIdleFunc(node)
- RF_DagNode_t *node;
+int
+rf_DiskReadMirrorIdleFunc(node)
+ RF_DagNode_t *node;
{
- /* select the mirror copy with the shortest queue and fill in node parameters
- with physical disk address */
+ /* select the mirror copy with the shortest queue and fill in node
+ * parameters with physical disk address */
- rf_SelectMirrorDiskIdle(node);
- return(rf_DiskReadFunc(node));
+ rf_SelectMirrorDiskIdle(node);
+ return (rf_DiskReadFunc(node));
}
-int rf_DiskReadMirrorPartitionFunc(node)
- RF_DagNode_t *node;
+int
+rf_DiskReadMirrorPartitionFunc(node)
+ RF_DagNode_t *node;
{
- /* select the mirror copy with the shortest queue and fill in node parameters
- with physical disk address */
+ /* select the mirror copy with the shortest queue and fill in node
+ * parameters with physical disk address */
- rf_SelectMirrorDiskPartition(node);
- return(rf_DiskReadFunc(node));
+ rf_SelectMirrorDiskPartition(node);
+ return (rf_DiskReadFunc(node));
}
-int rf_DiskReadMirrorUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_DiskReadMirrorUndoFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
@@ -331,346 +169,350 @@ int rf_DiskReadMirrorUndoFunc(node)
/*****************************************************************************************
* the execution function associated with a parity log update node
****************************************************************************************/
-int rf_ParityLogUpdateFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogUpdateFunc(node)
+ RF_DagNode_t *node;
{
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
- caddr_t buf = (caddr_t) node->params[1].p;
- RF_ParityLogData_t *logData;
- RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
- RF_Etimer_t timer;
-
- if (node->dagHdr->status == rf_enable)
- {
- RF_ETIMER_START(timer);
- logData = rf_CreateParityLogData(RF_UPDATE, pda, buf,
- (RF_Raid_t *) (node->dagHdr->raidPtr),
- node->wakeFunc, (void *) node,
- node->dagHdr->tracerec, timer);
- if (logData)
- rf_ParityLogAppend(logData, RF_FALSE, NULL, RF_FALSE);
- else
- {
- RF_ETIMER_STOP(timer); RF_ETIMER_EVAL(timer); tracerec->plog_us += RF_ETIMER_VAL_US(timer);
- (node->wakeFunc)(node, ENOMEM);
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ caddr_t buf = (caddr_t) node->params[1].p;
+ RF_ParityLogData_t *logData;
+ RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
+ RF_Etimer_t timer;
+
+ if (node->dagHdr->status == rf_enable) {
+ RF_ETIMER_START(timer);
+ logData = rf_CreateParityLogData(RF_UPDATE, pda, buf,
+ (RF_Raid_t *) (node->dagHdr->raidPtr),
+ node->wakeFunc, (void *) node,
+ node->dagHdr->tracerec, timer);
+ if (logData)
+ rf_ParityLogAppend(logData, RF_FALSE, NULL, RF_FALSE);
+ else {
+ RF_ETIMER_STOP(timer);
+ RF_ETIMER_EVAL(timer);
+ tracerec->plog_us += RF_ETIMER_VAL_US(timer);
+ (node->wakeFunc) (node, ENOMEM);
+ }
}
- }
- return(0);
+ return (0);
}
/*****************************************************************************************
* the execution function associated with a parity log overwrite node
****************************************************************************************/
-int rf_ParityLogOverwriteFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogOverwriteFunc(node)
+ RF_DagNode_t *node;
{
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
- caddr_t buf = (caddr_t) node->params[1].p;
- RF_ParityLogData_t *logData;
- RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
- RF_Etimer_t timer;
-
- if (node->dagHdr->status == rf_enable)
- {
- RF_ETIMER_START(timer);
- logData = rf_CreateParityLogData(RF_OVERWRITE, pda, buf, (RF_Raid_t *) (node->dagHdr->raidPtr),
- node->wakeFunc, (void *) node, node->dagHdr->tracerec, timer);
- if (logData)
- rf_ParityLogAppend(logData, RF_FALSE, NULL, RF_FALSE);
- else
- {
- RF_ETIMER_STOP(timer); RF_ETIMER_EVAL(timer); tracerec->plog_us += RF_ETIMER_VAL_US(timer);
- (node->wakeFunc)(node, ENOMEM);
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ caddr_t buf = (caddr_t) node->params[1].p;
+ RF_ParityLogData_t *logData;
+ RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
+ RF_Etimer_t timer;
+
+ if (node->dagHdr->status == rf_enable) {
+ RF_ETIMER_START(timer);
+ logData = rf_CreateParityLogData(RF_OVERWRITE, pda, buf, (RF_Raid_t *) (node->dagHdr->raidPtr),
+ node->wakeFunc, (void *) node, node->dagHdr->tracerec, timer);
+ if (logData)
+ rf_ParityLogAppend(logData, RF_FALSE, NULL, RF_FALSE);
+ else {
+ RF_ETIMER_STOP(timer);
+ RF_ETIMER_EVAL(timer);
+ tracerec->plog_us += RF_ETIMER_VAL_US(timer);
+ (node->wakeFunc) (node, ENOMEM);
+ }
}
- }
- return(0);
+ return (0);
}
+#else /* RF_INCLUDE_PARITYLOGGING > 0 */
-#else /* RF_INCLUDE_PARITYLOGGING > 0 */
-
-int rf_ParityLogUpdateFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogUpdateFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
-int rf_ParityLogOverwriteFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogOverwriteFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
+#endif /* RF_INCLUDE_PARITYLOGGING > 0 */
-#endif /* RF_INCLUDE_PARITYLOGGING > 0 */
-
-int rf_ParityLogUpdateUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogUpdateUndoFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
-int rf_ParityLogOverwriteUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_ParityLogOverwriteUndoFunc(node)
+ RF_DagNode_t *node;
{
- return(0);
+ return (0);
}
-
/*****************************************************************************************
* the execution function associated with a NOP node
****************************************************************************************/
-int rf_NullNodeFunc(node)
- RF_DagNode_t *node;
+int
+rf_NullNodeFunc(node)
+ RF_DagNode_t *node;
{
- node->status = rf_good;
- return(rf_FinishNode(node, RF_THREAD_CONTEXT));
+ node->status = rf_good;
+ return (rf_FinishNode(node, RF_THREAD_CONTEXT));
}
-int rf_NullNodeUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_NullNodeUndoFunc(node)
+ RF_DagNode_t *node;
{
- node->status = rf_undone;
- return(rf_FinishNode(node, RF_THREAD_CONTEXT));
+ node->status = rf_undone;
+ return (rf_FinishNode(node, RF_THREAD_CONTEXT));
}
/*****************************************************************************************
* the execution function associated with a disk-read node
****************************************************************************************/
-int rf_DiskReadFuncForThreads(node)
- RF_DagNode_t *node;
+int
+rf_DiskReadFuncForThreads(node)
+ RF_DagNode_t *node;
{
- RF_DiskQueueData_t *req;
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *)node->params[0].p;
- caddr_t buf = (caddr_t)node->params[1].p;
- RF_StripeNum_t parityStripeID = (RF_StripeNum_t)node->params[2].v;
- unsigned priority = RF_EXTRACT_PRIORITY(node->params[3].v);
- unsigned lock = RF_EXTRACT_LOCK_FLAG(node->params[3].v);
- unsigned unlock = RF_EXTRACT_UNLOCK_FLAG(node->params[3].v);
- unsigned which_ru = RF_EXTRACT_RU(node->params[3].v);
- RF_DiskQueueDataFlags_t flags = 0;
- RF_IoType_t iotype = (node->dagHdr->status == rf_enable) ? RF_IO_TYPE_READ : RF_IO_TYPE_NOP;
- RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
- void *b_proc = NULL;
+ RF_DiskQueueData_t *req;
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ caddr_t buf = (caddr_t) node->params[1].p;
+ RF_StripeNum_t parityStripeID = (RF_StripeNum_t) node->params[2].v;
+ unsigned priority = RF_EXTRACT_PRIORITY(node->params[3].v);
+ unsigned lock = RF_EXTRACT_LOCK_FLAG(node->params[3].v);
+ unsigned unlock = RF_EXTRACT_UNLOCK_FLAG(node->params[3].v);
+ unsigned which_ru = RF_EXTRACT_RU(node->params[3].v);
+ RF_DiskQueueDataFlags_t flags = 0;
+ RF_IoType_t iotype = (node->dagHdr->status == rf_enable) ? RF_IO_TYPE_READ : RF_IO_TYPE_NOP;
+ RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
+ void *b_proc = NULL;
#if RF_BACKWARD > 0
- caddr_t undoBuf;
+ caddr_t undoBuf;
#endif
-#ifdef KERNEL
- if (node->dagHdr->bp) b_proc = (void *) ((struct buf *) node->dagHdr->bp)->b_proc;
-#endif /* KERNEL */
+ if (node->dagHdr->bp)
+ b_proc = (void *) ((struct buf *) node->dagHdr->bp)->b_proc;
- RF_ASSERT( !(lock && unlock) );
- flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
- flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
+ RF_ASSERT(!(lock && unlock));
+ flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
+ flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
#if RF_BACKWARD > 0
- /* allocate and zero the undo buffer.
- * this is equivalent to copying the original buffer's contents to the undo buffer
- * prior to performing the disk read.
- * XXX hardcoded 512 bytes per sector!
- */
- if (node->dagHdr->allocList == NULL)
- rf_MakeAllocList(node->dagHdr->allocList);
- RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
-#endif /* RF_BACKWARD > 0 */
- req = rf_CreateDiskQueueData(iotype, pda->startSector, pda->numSector,
- buf, parityStripeID, which_ru,
- (int (*)(void *,int)) node->wakeFunc,
- node, NULL, node->dagHdr->tracerec,
- (void *)(node->dagHdr->raidPtr), flags, b_proc);
- if (!req) {
- (node->wakeFunc)(node, ENOMEM);
- } else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, priority );
- }
- return(0);
+ /* allocate and zero the undo buffer. this is equivalent to copying
+ * the original buffer's contents to the undo buffer prior to
+ * performing the disk read. XXX hardcoded 512 bytes per sector! */
+ if (node->dagHdr->allocList == NULL)
+ rf_MakeAllocList(node->dagHdr->allocList);
+ RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
+#endif /* RF_BACKWARD > 0 */
+ req = rf_CreateDiskQueueData(iotype, pda->startSector, pda->numSector,
+ buf, parityStripeID, which_ru,
+ (int (*) (void *, int)) node->wakeFunc,
+ node, NULL, node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr), flags, b_proc);
+ if (!req) {
+ (node->wakeFunc) (node, ENOMEM);
+ } else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, priority);
+ }
+ return (0);
}
/*****************************************************************************************
* the execution function associated with a disk-write node
****************************************************************************************/
-int rf_DiskWriteFuncForThreads(node)
- RF_DagNode_t *node;
+int
+rf_DiskWriteFuncForThreads(node)
+ RF_DagNode_t *node;
{
- RF_DiskQueueData_t *req;
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *)node->params[0].p;
- caddr_t buf = (caddr_t)node->params[1].p;
- RF_StripeNum_t parityStripeID = (RF_StripeNum_t)node->params[2].v;
- unsigned priority = RF_EXTRACT_PRIORITY(node->params[3].v);
- unsigned lock = RF_EXTRACT_LOCK_FLAG(node->params[3].v);
- unsigned unlock = RF_EXTRACT_UNLOCK_FLAG(node->params[3].v);
- unsigned which_ru = RF_EXTRACT_RU(node->params[3].v);
- RF_DiskQueueDataFlags_t flags = 0;
- RF_IoType_t iotype = (node->dagHdr->status == rf_enable) ? RF_IO_TYPE_WRITE : RF_IO_TYPE_NOP;
- RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
- void *b_proc = NULL;
+ RF_DiskQueueData_t *req;
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ caddr_t buf = (caddr_t) node->params[1].p;
+ RF_StripeNum_t parityStripeID = (RF_StripeNum_t) node->params[2].v;
+ unsigned priority = RF_EXTRACT_PRIORITY(node->params[3].v);
+ unsigned lock = RF_EXTRACT_LOCK_FLAG(node->params[3].v);
+ unsigned unlock = RF_EXTRACT_UNLOCK_FLAG(node->params[3].v);
+ unsigned which_ru = RF_EXTRACT_RU(node->params[3].v);
+ RF_DiskQueueDataFlags_t flags = 0;
+ RF_IoType_t iotype = (node->dagHdr->status == rf_enable) ? RF_IO_TYPE_WRITE : RF_IO_TYPE_NOP;
+ RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
+ void *b_proc = NULL;
#if RF_BACKWARD > 0
- caddr_t undoBuf;
+ caddr_t undoBuf;
#endif
-#ifdef KERNEL
- if (node->dagHdr->bp) b_proc = (void *) ((struct buf *) node->dagHdr->bp)->b_proc;
-#endif /* KERNEL */
+ if (node->dagHdr->bp)
+ b_proc = (void *) ((struct buf *) node->dagHdr->bp)->b_proc;
#if RF_BACKWARD > 0
- /* This area is used only for backward error recovery experiments
- * First, schedule allocate a buffer and schedule a pre-read of the disk
- * After the pre-read, proceed with the normal disk write
- */
- if (node->status == rf_bwd2) {
- /* just finished undo logging, now perform real function */
- node->status = rf_fired;
- RF_ASSERT( !(lock && unlock) );
- flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
- flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
- req = rf_CreateDiskQueueData(iotype,
- pda->startSector, pda->numSector, buf, parityStripeID, which_ru,
- node->wakeFunc, (void *) node, NULL, node->dagHdr->tracerec,
- (void *) (node->dagHdr->raidPtr), flags, b_proc);
-
- if (!req) {
- (node->wakeFunc)(node, ENOMEM);
- } else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, priority );
- }
- }
-
- else {
- /* node status should be rf_fired */
- /* schedule a disk pre-read */
- node->status = rf_bwd1;
- RF_ASSERT( !(lock && unlock) );
- flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
- flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
- if (node->dagHdr->allocList == NULL)
- rf_MakeAllocList(node->dagHdr->allocList);
- RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
- req = rf_CreateDiskQueueData(RF_IO_TYPE_READ,
- pda->startSector, pda->numSector, undoBuf, parityStripeID, which_ru,
- node->wakeFunc, (void *) node, NULL, node->dagHdr->tracerec,
- (void *) (node->dagHdr->raidPtr), flags, b_proc);
-
- if (!req) {
- (node->wakeFunc)(node, ENOMEM);
- } else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, priority );
- }
- }
- return(0);
-#endif /* RF_BACKWARD > 0 */
-
- /* normal processing (rollaway or forward recovery) begins here */
- RF_ASSERT( !(lock && unlock) );
- flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
- flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
- req = rf_CreateDiskQueueData(iotype, pda->startSector, pda->numSector,
- buf, parityStripeID, which_ru,
- (int (*)(void *,int)) node->wakeFunc,
- (void *) node, NULL,
- node->dagHdr->tracerec,
- (void *) (node->dagHdr->raidPtr),
- flags, b_proc);
-
- if (!req) {
- (node->wakeFunc)(node, ENOMEM);
- } else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, priority );
- }
-
- return(0);
-}
+ /* This area is used only for backward error recovery experiments
+ * First, schedule allocate a buffer and schedule a pre-read of the
+ * disk After the pre-read, proceed with the normal disk write */
+ if (node->status == rf_bwd2) {
+ /* just finished undo logging, now perform real function */
+ node->status = rf_fired;
+ RF_ASSERT(!(lock && unlock));
+ flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
+ flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
+ req = rf_CreateDiskQueueData(iotype,
+ pda->startSector, pda->numSector, buf, parityStripeID, which_ru,
+ node->wakeFunc, (void *) node, NULL, node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr), flags, b_proc);
+
+ if (!req) {
+ (node->wakeFunc) (node, ENOMEM);
+ } else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, priority);
+ }
+ } else {
+ /* node status should be rf_fired */
+ /* schedule a disk pre-read */
+ node->status = rf_bwd1;
+ RF_ASSERT(!(lock && unlock));
+ flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
+ flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
+ if (node->dagHdr->allocList == NULL)
+ rf_MakeAllocList(node->dagHdr->allocList);
+ RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
+ req = rf_CreateDiskQueueData(RF_IO_TYPE_READ,
+ pda->startSector, pda->numSector, undoBuf, parityStripeID, which_ru,
+ node->wakeFunc, (void *) node, NULL, node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr), flags, b_proc);
+
+ if (!req) {
+ (node->wakeFunc) (node, ENOMEM);
+ } else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, priority);
+ }
+ }
+ return (0);
+#endif /* RF_BACKWARD > 0 */
+
+ /* normal processing (rollaway or forward recovery) begins here */
+ RF_ASSERT(!(lock && unlock));
+ flags |= (lock) ? RF_LOCK_DISK_QUEUE : 0;
+ flags |= (unlock) ? RF_UNLOCK_DISK_QUEUE : 0;
+ req = rf_CreateDiskQueueData(iotype, pda->startSector, pda->numSector,
+ buf, parityStripeID, which_ru,
+ (int (*) (void *, int)) node->wakeFunc,
+ (void *) node, NULL,
+ node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr),
+ flags, b_proc);
+
+ if (!req) {
+ (node->wakeFunc) (node, ENOMEM);
+ } else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, priority);
+ }
+ return (0);
+}
/*****************************************************************************************
* the undo function for disk nodes
* Note: this is not a proper undo of a write node, only locks are released.
* old data is not restored to disk!
****************************************************************************************/
-int rf_DiskUndoFunc(node)
- RF_DagNode_t *node;
+int
+rf_DiskUndoFunc(node)
+ RF_DagNode_t *node;
{
- RF_DiskQueueData_t *req;
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *)node->params[0].p;
- RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
-
- req = rf_CreateDiskQueueData(RF_IO_TYPE_NOP,
- 0L, 0, NULL, 0L, 0,
- (int (*)(void *,int)) node->wakeFunc,
- (void *) node,
- NULL, node->dagHdr->tracerec,
- (void *) (node->dagHdr->raidPtr),
- RF_UNLOCK_DISK_QUEUE, NULL);
- if (!req)
- (node->wakeFunc)(node, ENOMEM);
- else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, RF_IO_NORMAL_PRIORITY );
- }
-
- return(0);
-}
+ RF_DiskQueueData_t *req;
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
+
+ req = rf_CreateDiskQueueData(RF_IO_TYPE_NOP,
+ 0L, 0, NULL, 0L, 0,
+ (int (*) (void *, int)) node->wakeFunc,
+ (void *) node,
+ NULL, node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr),
+ RF_UNLOCK_DISK_QUEUE, NULL);
+ if (!req)
+ (node->wakeFunc) (node, ENOMEM);
+ else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, RF_IO_NORMAL_PRIORITY);
+ }
+ return (0);
+}
/*****************************************************************************************
* the execution function associated with an "unlock disk queue" node
****************************************************************************************/
-int rf_DiskUnlockFuncForThreads(node)
- RF_DagNode_t *node;
+int
+rf_DiskUnlockFuncForThreads(node)
+ RF_DagNode_t *node;
{
- RF_DiskQueueData_t *req;
- RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *)node->params[0].p;
- RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
-
- req = rf_CreateDiskQueueData(RF_IO_TYPE_NOP,
- 0L, 0, NULL, 0L, 0,
- (int (*)(void *,int)) node->wakeFunc,
- (void *) node,
- NULL, node->dagHdr->tracerec,
- (void *) (node->dagHdr->raidPtr),
- RF_UNLOCK_DISK_QUEUE, NULL);
- if (!req)
- (node->wakeFunc)(node, ENOMEM);
- else {
- node->dagFuncData = (void *) req;
- rf_DiskIOEnqueue( &(dqs[pda->row][pda->col]), req, RF_IO_NORMAL_PRIORITY );
- }
-
- return(0);
-}
+ RF_DiskQueueData_t *req;
+ RF_PhysDiskAddr_t *pda = (RF_PhysDiskAddr_t *) node->params[0].p;
+ RF_DiskQueue_t **dqs = ((RF_Raid_t *) (node->dagHdr->raidPtr))->Queues;
+
+ req = rf_CreateDiskQueueData(RF_IO_TYPE_NOP,
+ 0L, 0, NULL, 0L, 0,
+ (int (*) (void *, int)) node->wakeFunc,
+ (void *) node,
+ NULL, node->dagHdr->tracerec,
+ (void *) (node->dagHdr->raidPtr),
+ RF_UNLOCK_DISK_QUEUE, NULL);
+ if (!req)
+ (node->wakeFunc) (node, ENOMEM);
+ else {
+ node->dagFuncData = (void *) req;
+ rf_DiskIOEnqueue(&(dqs[pda->row][pda->col]), req, RF_IO_NORMAL_PRIORITY);
+ }
+ return (0);
+}
/*****************************************************************************************
* Callback routine for DiskRead and DiskWrite nodes. When the disk op completes,
* the routine is called to set the node status and inform the execution engine that
* the node has fired.
****************************************************************************************/
-int rf_GenericWakeupFunc(node, status)
- RF_DagNode_t *node;
- int status;
+int
+rf_GenericWakeupFunc(node, status)
+ RF_DagNode_t *node;
+ int status;
{
- switch (node->status) {
- case rf_bwd1 :
- node->status = rf_bwd2;
- if (node->dagFuncData)
- rf_FreeDiskQueueData((RF_DiskQueueData_t *) node->dagFuncData);
- return(rf_DiskWriteFuncForThreads(node));
- break;
- case rf_fired :
- if (status) node->status = rf_bad;
- else node->status = rf_good;
- break;
- case rf_recover :
- /* probably should never reach this case */
- if (status) node->status = rf_panic;
- else node->status = rf_undone;
- break;
- default :
- RF_PANIC();
- break;
- }
- if (node->dagFuncData)
- rf_FreeDiskQueueData((RF_DiskQueueData_t *) node->dagFuncData);
- return(rf_FinishNode(node, RF_INTR_CONTEXT));
+ switch (node->status) {
+ case rf_bwd1:
+ node->status = rf_bwd2;
+ if (node->dagFuncData)
+ rf_FreeDiskQueueData((RF_DiskQueueData_t *) node->dagFuncData);
+ return (rf_DiskWriteFuncForThreads(node));
+ break;
+ case rf_fired:
+ if (status)
+ node->status = rf_bad;
+ else
+ node->status = rf_good;
+ break;
+ case rf_recover:
+ /* probably should never reach this case */
+ if (status)
+ node->status = rf_panic;
+ else
+ node->status = rf_undone;
+ break;
+ default:
+ RF_PANIC();
+ break;
+ }
+ if (node->dagFuncData)
+ rf_FreeDiskQueueData((RF_DiskQueueData_t *) node->dagFuncData);
+ return (rf_FinishNode(node, RF_INTR_CONTEXT));
}
@@ -696,78 +538,87 @@ int rf_GenericWakeupFunc(node, status)
* and use the pda params to determine where within the buffer to XOR
* the input buffers.
*/
-int rf_RegularXorFunc(node)
- RF_DagNode_t *node;
+int
+rf_RegularXorFunc(node)
+ RF_DagNode_t *node;
{
- RF_Raid_t *raidPtr = (RF_Raid_t *)node->params[node->numParams-1].p;
- RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
- RF_Etimer_t timer;
- int i, retcode;
+ RF_Raid_t *raidPtr = (RF_Raid_t *) node->params[node->numParams - 1].p;
+ RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
+ RF_Etimer_t timer;
+ int i, retcode;
#if RF_BACKWARD > 0
- RF_PhysDiskAddr_t *pda;
- caddr_t undoBuf;
+ RF_PhysDiskAddr_t *pda;
+ caddr_t undoBuf;
#endif
- retcode = 0;
- if (node->dagHdr->status == rf_enable) {
- /* don't do the XOR if the input is the same as the output */
- RF_ETIMER_START(timer);
- for (i=0; i<node->numParams-1; i+=2) if (node->params[i+1].p != node->results[0]) {
+ retcode = 0;
+ if (node->dagHdr->status == rf_enable) {
+ /* don't do the XOR if the input is the same as the output */
+ RF_ETIMER_START(timer);
+ for (i = 0; i < node->numParams - 1; i += 2)
+ if (node->params[i + 1].p != node->results[0]) {
#if RF_BACKWARD > 0
- /* This section mimics undo logging for backward error recovery experiments b
- * allocating and initializing a buffer
- * XXX 512 byte sector size is hard coded!
- */
- pda = node->params[i].p;
- if (node->dagHdr->allocList == NULL)
- rf_MakeAllocList(node->dagHdr->allocList);
- RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
-#endif /* RF_BACKWARD > 0 */
- retcode = rf_XorIntoBuffer(raidPtr, (RF_PhysDiskAddr_t *) node->params[i].p,
- (char *)node->params[i+1].p, (char *) node->results[0], node->dagHdr->bp);
- }
- RF_ETIMER_STOP(timer); RF_ETIMER_EVAL(timer); tracerec->xor_us += RF_ETIMER_VAL_US(timer);
- }
- return(rf_GenericWakeupFunc(node, retcode)); /* call wake func explicitly since no I/O in this node */
+ /* This section mimics undo logging for
+ * backward error recovery experiments b
+ * allocating and initializing a buffer XXX
+ * 512 byte sector size is hard coded! */
+ pda = node->params[i].p;
+ if (node->dagHdr->allocList == NULL)
+ rf_MakeAllocList(node->dagHdr->allocList);
+ RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
+#endif /* RF_BACKWARD > 0 */
+ retcode = rf_XorIntoBuffer(raidPtr, (RF_PhysDiskAddr_t *) node->params[i].p,
+ (char *) node->params[i + 1].p, (char *) node->results[0], node->dagHdr->bp);
+ }
+ RF_ETIMER_STOP(timer);
+ RF_ETIMER_EVAL(timer);
+ tracerec->xor_us += RF_ETIMER_VAL_US(timer);
+ }
+ return (rf_GenericWakeupFunc(node, retcode)); /* call wake func
+ * explicitly since no
+ * I/O in this node */
}
-
/* xor the inputs into the result buffer, ignoring placement issues */
-int rf_SimpleXorFunc(node)
- RF_DagNode_t *node;
+int
+rf_SimpleXorFunc(node)
+ RF_DagNode_t *node;
{
- RF_Raid_t *raidPtr = (RF_Raid_t *)node->params[node->numParams-1].p;
- int i, retcode = 0;
- RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
- RF_Etimer_t timer;
+ RF_Raid_t *raidPtr = (RF_Raid_t *) node->params[node->numParams - 1].p;
+ int i, retcode = 0;
+ RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
+ RF_Etimer_t timer;
#if RF_BACKWARD > 0
- RF_PhysDiskAddr_t *pda;
- caddr_t undoBuf;
+ RF_PhysDiskAddr_t *pda;
+ caddr_t undoBuf;
#endif
- if (node->dagHdr->status == rf_enable) {
- RF_ETIMER_START(timer);
- /* don't do the XOR if the input is the same as the output */
- for (i=0; i<node->numParams-1; i+=2) if (node->params[i+1].p != node->results[0]) {
+ if (node->dagHdr->status == rf_enable) {
+ RF_ETIMER_START(timer);
+ /* don't do the XOR if the input is the same as the output */
+ for (i = 0; i < node->numParams - 1; i += 2)
+ if (node->params[i + 1].p != node->results[0]) {
#if RF_BACKWARD > 0
- /* This section mimics undo logging for backward error recovery experiments b
- * allocating and initializing a buffer
- * XXX 512 byte sector size is hard coded!
- */
- pda = node->params[i].p;
- if (node->dagHdr->allocList == NULL)
- rf_MakeAllocList(node->dagHdr->allocList);
- RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
-#endif /* RF_BACKWARD > 0 */
- retcode = rf_bxor((char *)node->params[i+1].p, (char *) node->results[0],
- rf_RaidAddressToByte(raidPtr, ((RF_PhysDiskAddr_t *)node->params[i].p)->numSector),
- (struct buf *) node->dagHdr->bp);
- }
- RF_ETIMER_STOP(timer); RF_ETIMER_EVAL(timer); tracerec->xor_us += RF_ETIMER_VAL_US(timer);
- }
-
- return(rf_GenericWakeupFunc(node, retcode)); /* call wake func explicitly since no I/O in this node */
+ /* This section mimics undo logging for
+ * backward error recovery experiments b
+ * allocating and initializing a buffer XXX
+ * 512 byte sector size is hard coded! */
+ pda = node->params[i].p;
+ if (node->dagHdr->allocList == NULL)
+ rf_MakeAllocList(node->dagHdr->allocList);
+ RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
+#endif /* RF_BACKWARD > 0 */
+ retcode = rf_bxor((char *) node->params[i + 1].p, (char *) node->results[0],
+ rf_RaidAddressToByte(raidPtr, ((RF_PhysDiskAddr_t *) node->params[i].p)->numSector),
+ (struct buf *) node->dagHdr->bp);
+ }
+ RF_ETIMER_STOP(timer);
+ RF_ETIMER_EVAL(timer);
+ tracerec->xor_us += RF_ETIMER_VAL_US(timer);
+ }
+ return (rf_GenericWakeupFunc(node, retcode)); /* call wake func
+ * explicitly since no
+ * I/O in this node */
}
-
/* this xor is used by the degraded-mode dag functions to recover lost data.
* the second-to-last parameter is the PDA for the failed portion of the access.
* the code here looks at this PDA and assumes that the xor target buffer is
@@ -775,45 +626,48 @@ int rf_SimpleXorFunc(node)
* the other PDAs in the parameter list to determine where within the target
* buffer the corresponding data should be xored.
*/
-int rf_RecoveryXorFunc(node)
- RF_DagNode_t *node;
+int
+rf_RecoveryXorFunc(node)
+ RF_DagNode_t *node;
{
- RF_Raid_t *raidPtr = (RF_Raid_t *)node->params[node->numParams-1].p;
- RF_RaidLayout_t *layoutPtr = (RF_RaidLayout_t *) &raidPtr->Layout;
- RF_PhysDiskAddr_t *failedPDA = (RF_PhysDiskAddr_t *)node->params[node->numParams-2].p;
- int i, retcode = 0;
- RF_PhysDiskAddr_t *pda;
- int suoffset, failedSUOffset = rf_StripeUnitOffset(layoutPtr,failedPDA->startSector);
- char *srcbuf, *destbuf;
- RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
- RF_Etimer_t timer;
+ RF_Raid_t *raidPtr = (RF_Raid_t *) node->params[node->numParams - 1].p;
+ RF_RaidLayout_t *layoutPtr = (RF_RaidLayout_t *) & raidPtr->Layout;
+ RF_PhysDiskAddr_t *failedPDA = (RF_PhysDiskAddr_t *) node->params[node->numParams - 2].p;
+ int i, retcode = 0;
+ RF_PhysDiskAddr_t *pda;
+ int suoffset, failedSUOffset = rf_StripeUnitOffset(layoutPtr, failedPDA->startSector);
+ char *srcbuf, *destbuf;
+ RF_AccTraceEntry_t *tracerec = node->dagHdr->tracerec;
+ RF_Etimer_t timer;
#if RF_BACKWARD > 0
- caddr_t undoBuf;
+ caddr_t undoBuf;
#endif
- if (node->dagHdr->status == rf_enable) {
- RF_ETIMER_START(timer);
- for (i=0; i<node->numParams-2; i+=2) if (node->params[i+1].p != node->results[0]) {
- pda = (RF_PhysDiskAddr_t *)node->params[i].p;
+ if (node->dagHdr->status == rf_enable) {
+ RF_ETIMER_START(timer);
+ for (i = 0; i < node->numParams - 2; i += 2)
+ if (node->params[i + 1].p != node->results[0]) {
+ pda = (RF_PhysDiskAddr_t *) node->params[i].p;
#if RF_BACKWARD > 0
- /* This section mimics undo logging for backward error recovery experiments b
- * allocating and initializing a buffer
- * XXX 512 byte sector size is hard coded!
- */
- if (node->dagHdr->allocList == NULL)
- rf_MakeAllocList(node->dagHdr->allocList);
- RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
-#endif /* RF_BACKWARD > 0 */
- srcbuf = (char *)node->params[i+1].p;
- suoffset = rf_StripeUnitOffset(layoutPtr, pda->startSector);
- destbuf = ((char *) node->results[0]) + rf_RaidAddressToByte(raidPtr,suoffset-failedSUOffset);
- retcode = rf_bxor(srcbuf, destbuf, rf_RaidAddressToByte(raidPtr, pda->numSector), node->dagHdr->bp);
- }
- RF_ETIMER_STOP(timer); RF_ETIMER_EVAL(timer); tracerec->xor_us += RF_ETIMER_VAL_US(timer);
- }
- return (rf_GenericWakeupFunc(node, retcode));
+ /* This section mimics undo logging for
+ * backward error recovery experiments b
+ * allocating and initializing a buffer XXX
+ * 512 byte sector size is hard coded! */
+ if (node->dagHdr->allocList == NULL)
+ rf_MakeAllocList(node->dagHdr->allocList);
+ RF_CallocAndAdd(undoBuf, 1, 512 * pda->numSector, (caddr_t), node->dagHdr->allocList);
+#endif /* RF_BACKWARD > 0 */
+ srcbuf = (char *) node->params[i + 1].p;
+ suoffset = rf_StripeUnitOffset(layoutPtr, pda->startSector);
+ destbuf = ((char *) node->results[0]) + rf_RaidAddressToByte(raidPtr, suoffset - failedSUOffset);
+ retcode = rf_bxor(srcbuf, destbuf, rf_RaidAddressToByte(raidPtr, pda->numSector), node->dagHdr->bp);
+ }
+ RF_ETIMER_STOP(timer);
+ RF_ETIMER_EVAL(timer);
+ tracerec->xor_us += RF_ETIMER_VAL_US(timer);
+ }
+ return (rf_GenericWakeupFunc(node, retcode));
}
-
/*****************************************************************************************
* The next three functions are utilities used by the above xor-execution functions.
****************************************************************************************/
@@ -827,58 +681,49 @@ int rf_RecoveryXorFunc(node)
* SU in size the XOR occurs on only the portion of targbuf identified in the pda.
*/
-int rf_XorIntoBuffer(raidPtr, pda, srcbuf, targbuf, bp)
- RF_Raid_t *raidPtr;
- RF_PhysDiskAddr_t *pda;
- char *srcbuf;
- char *targbuf;
- void *bp;
+int
+rf_XorIntoBuffer(raidPtr, pda, srcbuf, targbuf, bp)
+ RF_Raid_t *raidPtr;
+ RF_PhysDiskAddr_t *pda;
+ char *srcbuf;
+ char *targbuf;
+ void *bp;
{
- char *targptr;
- int sectPerSU = raidPtr->Layout.sectorsPerStripeUnit;
- int SUOffset = pda->startSector % sectPerSU;
- int length, retcode = 0;
-
- RF_ASSERT(pda->numSector <= sectPerSU);
-
- targptr = targbuf + rf_RaidAddressToByte(raidPtr, SUOffset);
- length = rf_RaidAddressToByte(raidPtr, pda->numSector);
- retcode = rf_bxor(srcbuf, targptr, length, bp);
- return(retcode);
-}
+ char *targptr;
+ int sectPerSU = raidPtr->Layout.sectorsPerStripeUnit;
+ int SUOffset = pda->startSector % sectPerSU;
+ int length, retcode = 0;
+
+ RF_ASSERT(pda->numSector <= sectPerSU);
+ targptr = targbuf + rf_RaidAddressToByte(raidPtr, SUOffset);
+ length = rf_RaidAddressToByte(raidPtr, pda->numSector);
+ retcode = rf_bxor(srcbuf, targptr, length, bp);
+ return (retcode);
+}
/* it really should be the case that the buffer pointers (returned by malloc)
* are aligned to the natural word size of the machine, so this is the only
* case we optimize for. The length should always be a multiple of the sector
* size, so there should be no problem with leftover bytes at the end.
*/
-int rf_bxor(src, dest, len, bp)
- char *src;
- char *dest;
- int len;
- void *bp;
+int
+rf_bxor(src, dest, len, bp)
+ char *src;
+ char *dest;
+ int len;
+ void *bp;
{
- unsigned mask = sizeof(long) -1, retcode = 0;
-
- if ( !(((unsigned long) src) & mask) && !(((unsigned long) dest) & mask) && !(len&mask) ) {
- retcode = rf_longword_bxor((unsigned long *) src, (unsigned long *) dest, len>>RF_LONGSHIFT, bp);
- } else {
- RF_ASSERT(0);
- }
- return(retcode);
-}
+ unsigned mask = sizeof(long) - 1, retcode = 0;
+ if (!(((unsigned long) src) & mask) && !(((unsigned long) dest) & mask) && !(len & mask)) {
+ retcode = rf_longword_bxor((unsigned long *) src, (unsigned long *) dest, len >> RF_LONGSHIFT, bp);
+ } else {
+ RF_ASSERT(0);
+ }
+ return (retcode);
+}
/* map a user buffer into kernel space, if necessary */
-#ifdef KERNEL
-#if defined(__NetBSD__) || defined(__OpenBSD__)
-/* XXX Not a clue if this is even close.. */
#define REMAP_VA(_bp,x,y) (y) = (x)
-#else
-#define REMAP_VA(_bp,x,y) (y) = (unsigned long *) ((IS_SYS_VA(x)) ? (unsigned long *)(x) : (unsigned long *) rf_MapToKernelSpace((struct buf *) (_bp), (caddr_t)(x)))
-#endif /* __NetBSD__ || __OpenBSD__ */
-#else /* KERNEL */
-#define REMAP_VA(_bp,x,y) (y) = (x)
-#endif /* KERNEL */
/* When XORing in kernel mode, we need to map each user page to kernel space before we can access it.
* We don't want to assume anything about which input buffers are in kernel/user
@@ -886,61 +731,75 @@ int rf_bxor(src, dest, len, bp)
* of bytes that we can xor without crossing any page boundaries, and do only this many
* bytes before the next remap.
*/
-int rf_longword_bxor(src, dest, len, bp)
- register unsigned long *src;
- register unsigned long *dest;
- int len; /* longwords */
- void *bp;
+int
+rf_longword_bxor(src, dest, len, bp)
+ register unsigned long *src;
+ register unsigned long *dest;
+ int len; /* longwords */
+ void *bp;
{
- register unsigned long *end = src+len;
- register unsigned long d0, d1, d2, d3, s0, s1, s2, s3; /* temps */
- register unsigned long *pg_src, *pg_dest; /* per-page source/dest pointers */
- int longs_this_time; /* # longwords to xor in the current iteration */
-
- REMAP_VA(bp, src, pg_src);
- REMAP_VA(bp, dest, pg_dest);
- if (!pg_src || !pg_dest) return(EFAULT);
-
- while (len >= 4 ) {
- longs_this_time = RF_MIN(len, RF_MIN(RF_BLIP(pg_src), RF_BLIP(pg_dest)) >> RF_LONGSHIFT); /* note len in longwords */
- src += longs_this_time; dest+= longs_this_time; len -= longs_this_time;
- while (longs_this_time >= 4) {
- d0 = pg_dest[0];
- d1 = pg_dest[1];
- d2 = pg_dest[2];
- d3 = pg_dest[3];
- s0 = pg_src[0];
- s1 = pg_src[1];
- s2 = pg_src[2];
- s3 = pg_src[3];
- pg_dest[0] = d0 ^ s0;
- pg_dest[1] = d1 ^ s1;
- pg_dest[2] = d2 ^ s2;
- pg_dest[3] = d3 ^ s3;
- pg_src += 4;
- pg_dest += 4;
- longs_this_time -= 4;
- }
- while (longs_this_time > 0) { /* cannot cross any page boundaries here */
- *pg_dest++ ^= *pg_src++;
- longs_this_time--;
- }
-
- /* either we're done, or we've reached a page boundary on one (or possibly both) of the pointers */
- if (len) {
- if (RF_PAGE_ALIGNED(src)) REMAP_VA(bp, src, pg_src);
- if (RF_PAGE_ALIGNED(dest)) REMAP_VA(bp, dest, pg_dest);
- if (!pg_src || !pg_dest) return(EFAULT);
- }
- }
- while (src < end) {
- *pg_dest++ ^= *pg_src++;
- src++; dest++; len--;
- if (RF_PAGE_ALIGNED(src)) REMAP_VA(bp, src, pg_src);
- if (RF_PAGE_ALIGNED(dest)) REMAP_VA(bp, dest, pg_dest);
- }
- RF_ASSERT(len == 0);
- return(0);
+ register unsigned long *end = src + len;
+ register unsigned long d0, d1, d2, d3, s0, s1, s2, s3; /* temps */
+ register unsigned long *pg_src, *pg_dest; /* per-page source/dest
+ * pointers */
+ int longs_this_time;/* # longwords to xor in the current iteration */
+
+ REMAP_VA(bp, src, pg_src);
+ REMAP_VA(bp, dest, pg_dest);
+ if (!pg_src || !pg_dest)
+ return (EFAULT);
+
+ while (len >= 4) {
+ longs_this_time = RF_MIN(len, RF_MIN(RF_BLIP(pg_src), RF_BLIP(pg_dest)) >> RF_LONGSHIFT); /* note len in longwords */
+ src += longs_this_time;
+ dest += longs_this_time;
+ len -= longs_this_time;
+ while (longs_this_time >= 4) {
+ d0 = pg_dest[0];
+ d1 = pg_dest[1];
+ d2 = pg_dest[2];
+ d3 = pg_dest[3];
+ s0 = pg_src[0];
+ s1 = pg_src[1];
+ s2 = pg_src[2];
+ s3 = pg_src[3];
+ pg_dest[0] = d0 ^ s0;
+ pg_dest[1] = d1 ^ s1;
+ pg_dest[2] = d2 ^ s2;
+ pg_dest[3] = d3 ^ s3;
+ pg_src += 4;
+ pg_dest += 4;
+ longs_this_time -= 4;
+ }
+ while (longs_this_time > 0) { /* cannot cross any page
+ * boundaries here */
+ *pg_dest++ ^= *pg_src++;
+ longs_this_time--;
+ }
+
+ /* either we're done, or we've reached a page boundary on one
+ * (or possibly both) of the pointers */
+ if (len) {
+ if (RF_PAGE_ALIGNED(src))
+ REMAP_VA(bp, src, pg_src);
+ if (RF_PAGE_ALIGNED(dest))
+ REMAP_VA(bp, dest, pg_dest);
+ if (!pg_src || !pg_dest)
+ return (EFAULT);
+ }
+ }
+ while (src < end) {
+ *pg_dest++ ^= *pg_src++;
+ src++;
+ dest++;
+ len--;
+ if (RF_PAGE_ALIGNED(src))
+ REMAP_VA(bp, src, pg_src);
+ if (RF_PAGE_ALIGNED(dest))
+ REMAP_VA(bp, dest, pg_dest);
+ }
+ RF_ASSERT(len == 0);
+ return (0);
}
@@ -949,102 +808,182 @@ int rf_longword_bxor(src, dest, len, bp)
a may equal dst
see comment above longword_bxor
*/
-int rf_longword_bxor3(dst,a,b,c,len, bp)
- register unsigned long *dst;
- register unsigned long *a;
- register unsigned long *b;
- register unsigned long *c;
- int len; /* length in longwords */
- void *bp;
+int
+rf_longword_bxor3(dst, a, b, c, len, bp)
+ register unsigned long *dst;
+ register unsigned long *a;
+ register unsigned long *b;
+ register unsigned long *c;
+ int len; /* length in longwords */
+ void *bp;
{
- unsigned long a0,a1,a2,a3, b0,b1,b2,b3;
- register unsigned long *pg_a, *pg_b, *pg_c, *pg_dst; /* per-page source/dest pointers */
- int longs_this_time; /* # longs to xor in the current iteration */
- char dst_is_a = 0;
-
- REMAP_VA(bp, a, pg_a);
- REMAP_VA(bp, b, pg_b);
- REMAP_VA(bp, c, pg_c);
- if (a == dst) {pg_dst = pg_a; dst_is_a = 1;} else { REMAP_VA(bp, dst, pg_dst); }
-
- /* align dest to cache line. Can't cross a pg boundary on dst here. */
- while ((((unsigned long) pg_dst) & 0x1f)) {
- *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
- dst++; a++; b++; c++;
- if (RF_PAGE_ALIGNED(a)) {REMAP_VA(bp, a, pg_a); if (!pg_a) return(EFAULT);}
- if (RF_PAGE_ALIGNED(b)) {REMAP_VA(bp, a, pg_b); if (!pg_b) return(EFAULT);}
- if (RF_PAGE_ALIGNED(c)) {REMAP_VA(bp, a, pg_c); if (!pg_c) return(EFAULT);}
- len--;
- }
-
- while (len > 4 ) {
- longs_this_time = RF_MIN(len, RF_MIN(RF_BLIP(a), RF_MIN(RF_BLIP(b), RF_MIN(RF_BLIP(c), RF_BLIP(dst)))) >> RF_LONGSHIFT);
- a+= longs_this_time; b+= longs_this_time; c+= longs_this_time; dst+=longs_this_time; len-=longs_this_time;
- while (longs_this_time >= 4) {
- a0 = pg_a[0]; longs_this_time -= 4;
-
- a1 = pg_a[1];
- a2 = pg_a[2];
-
- a3 = pg_a[3]; pg_a += 4;
-
- b0 = pg_b[0];
- b1 = pg_b[1];
-
- b2 = pg_b[2];
- b3 = pg_b[3];
- /* start dual issue */
- a0 ^= b0; b0 = pg_c[0];
-
- pg_b += 4; a1 ^= b1;
-
- a2 ^= b2; a3 ^= b3;
-
- b1 = pg_c[1]; a0 ^= b0;
-
- b2 = pg_c[2]; a1 ^= b1;
-
- b3 = pg_c[3]; a2 ^= b2;
-
- pg_dst[0] = a0; a3 ^= b3;
- pg_dst[1] = a1; pg_c += 4;
- pg_dst[2] = a2;
- pg_dst[3] = a3; pg_dst += 4;
- }
- while (longs_this_time > 0) { /* cannot cross any page boundaries here */
- *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
- longs_this_time--;
- }
-
- if (len) {
- if (RF_PAGE_ALIGNED(a)) {REMAP_VA(bp, a, pg_a); if (!pg_a) return(EFAULT); if (dst_is_a) pg_dst = pg_a;}
- if (RF_PAGE_ALIGNED(b)) {REMAP_VA(bp, b, pg_b); if (!pg_b) return(EFAULT);}
- if (RF_PAGE_ALIGNED(c)) {REMAP_VA(bp, c, pg_c); if (!pg_c) return(EFAULT);}
- if (!dst_is_a) if (RF_PAGE_ALIGNED(dst)) {REMAP_VA(bp, dst, pg_dst); if (!pg_dst) return(EFAULT);}
- }
- }
- while (len) {
- *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
- dst++; a++; b++; c++;
- if (RF_PAGE_ALIGNED(a)) {REMAP_VA(bp, a, pg_a); if (!pg_a) return(EFAULT); if (dst_is_a) pg_dst = pg_a;}
- if (RF_PAGE_ALIGNED(b)) {REMAP_VA(bp, b, pg_b); if (!pg_b) return(EFAULT);}
- if (RF_PAGE_ALIGNED(c)) {REMAP_VA(bp, c, pg_c); if (!pg_c) return(EFAULT);}
- if (!dst_is_a) if (RF_PAGE_ALIGNED(dst)) {REMAP_VA(bp, dst, pg_dst); if (!pg_dst) return(EFAULT);}
- len--;
- }
- return(0);
+ unsigned long a0, a1, a2, a3, b0, b1, b2, b3;
+ register unsigned long *pg_a, *pg_b, *pg_c, *pg_dst; /* per-page source/dest
+ * pointers */
+ int longs_this_time;/* # longs to xor in the current iteration */
+ char dst_is_a = 0;
+
+ REMAP_VA(bp, a, pg_a);
+ REMAP_VA(bp, b, pg_b);
+ REMAP_VA(bp, c, pg_c);
+ if (a == dst) {
+ pg_dst = pg_a;
+ dst_is_a = 1;
+ } else {
+ REMAP_VA(bp, dst, pg_dst);
+ }
+
+ /* align dest to cache line. Can't cross a pg boundary on dst here. */
+ while ((((unsigned long) pg_dst) & 0x1f)) {
+ *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
+ dst++;
+ a++;
+ b++;
+ c++;
+ if (RF_PAGE_ALIGNED(a)) {
+ REMAP_VA(bp, a, pg_a);
+ if (!pg_a)
+ return (EFAULT);
+ }
+ if (RF_PAGE_ALIGNED(b)) {
+ REMAP_VA(bp, a, pg_b);
+ if (!pg_b)
+ return (EFAULT);
+ }
+ if (RF_PAGE_ALIGNED(c)) {
+ REMAP_VA(bp, a, pg_c);
+ if (!pg_c)
+ return (EFAULT);
+ }
+ len--;
+ }
+
+ while (len > 4) {
+ longs_this_time = RF_MIN(len, RF_MIN(RF_BLIP(a), RF_MIN(RF_BLIP(b), RF_MIN(RF_BLIP(c), RF_BLIP(dst)))) >> RF_LONGSHIFT);
+ a += longs_this_time;
+ b += longs_this_time;
+ c += longs_this_time;
+ dst += longs_this_time;
+ len -= longs_this_time;
+ while (longs_this_time >= 4) {
+ a0 = pg_a[0];
+ longs_this_time -= 4;
+
+ a1 = pg_a[1];
+ a2 = pg_a[2];
+
+ a3 = pg_a[3];
+ pg_a += 4;
+
+ b0 = pg_b[0];
+ b1 = pg_b[1];
+
+ b2 = pg_b[2];
+ b3 = pg_b[3];
+ /* start dual issue */
+ a0 ^= b0;
+ b0 = pg_c[0];
+
+ pg_b += 4;
+ a1 ^= b1;
+
+ a2 ^= b2;
+ a3 ^= b3;
+
+ b1 = pg_c[1];
+ a0 ^= b0;
+
+ b2 = pg_c[2];
+ a1 ^= b1;
+
+ b3 = pg_c[3];
+ a2 ^= b2;
+
+ pg_dst[0] = a0;
+ a3 ^= b3;
+ pg_dst[1] = a1;
+ pg_c += 4;
+ pg_dst[2] = a2;
+ pg_dst[3] = a3;
+ pg_dst += 4;
+ }
+ while (longs_this_time > 0) { /* cannot cross any page
+ * boundaries here */
+ *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
+ longs_this_time--;
+ }
+
+ if (len) {
+ if (RF_PAGE_ALIGNED(a)) {
+ REMAP_VA(bp, a, pg_a);
+ if (!pg_a)
+ return (EFAULT);
+ if (dst_is_a)
+ pg_dst = pg_a;
+ }
+ if (RF_PAGE_ALIGNED(b)) {
+ REMAP_VA(bp, b, pg_b);
+ if (!pg_b)
+ return (EFAULT);
+ }
+ if (RF_PAGE_ALIGNED(c)) {
+ REMAP_VA(bp, c, pg_c);
+ if (!pg_c)
+ return (EFAULT);
+ }
+ if (!dst_is_a)
+ if (RF_PAGE_ALIGNED(dst)) {
+ REMAP_VA(bp, dst, pg_dst);
+ if (!pg_dst)
+ return (EFAULT);
+ }
+ }
+ }
+ while (len) {
+ *pg_dst++ = *pg_a++ ^ *pg_b++ ^ *pg_c++;
+ dst++;
+ a++;
+ b++;
+ c++;
+ if (RF_PAGE_ALIGNED(a)) {
+ REMAP_VA(bp, a, pg_a);
+ if (!pg_a)
+ return (EFAULT);
+ if (dst_is_a)
+ pg_dst = pg_a;
+ }
+ if (RF_PAGE_ALIGNED(b)) {
+ REMAP_VA(bp, b, pg_b);
+ if (!pg_b)
+ return (EFAULT);
+ }
+ if (RF_PAGE_ALIGNED(c)) {
+ REMAP_VA(bp, c, pg_c);
+ if (!pg_c)
+ return (EFAULT);
+ }
+ if (!dst_is_a)
+ if (RF_PAGE_ALIGNED(dst)) {
+ REMAP_VA(bp, dst, pg_dst);
+ if (!pg_dst)
+ return (EFAULT);
+ }
+ len--;
+ }
+ return (0);
}
-int rf_bxor3(dst,a,b,c,len, bp)
- register unsigned char *dst;
- register unsigned char *a;
- register unsigned char *b;
- register unsigned char *c;
- unsigned long len;
- void *bp;
+int
+rf_bxor3(dst, a, b, c, len, bp)
+ register unsigned char *dst;
+ register unsigned char *a;
+ register unsigned char *b;
+ register unsigned char *c;
+ unsigned long len;
+ void *bp;
{
- RF_ASSERT(((RF_UL(dst)|RF_UL(a)|RF_UL(b)|RF_UL(c)|len) & 0x7) == 0);
+ RF_ASSERT(((RF_UL(dst) | RF_UL(a) | RF_UL(b) | RF_UL(c) | len) & 0x7) == 0);
- return(rf_longword_bxor3((unsigned long *)dst, (unsigned long *)a,
- (unsigned long *)b, (unsigned long *)c, len>>RF_LONGSHIFT, bp));
+ return (rf_longword_bxor3((unsigned long *) dst, (unsigned long *) a,
+ (unsigned long *) b, (unsigned long *) c, len >> RF_LONGSHIFT, bp));
}