diff options
| author | Martin Pieuchot <mpi@cvs.openbsd.org> | 2018-02-19 08:59:54 +0000 |
|---|---|---|
| committer | Martin Pieuchot <mpi@cvs.openbsd.org> | 2018-02-19 08:59:54 +0000 |
| commit | f44ff454cd0da5e1133d8f57877628c13d346dc5 (patch) | |
| tree | a859411ce3744fe07063c4159a939baca3f01e49 /sys/dev/usb | |
| parent | 4272ed38eae20e0ca38fa48ddd2fcc64c78d02ec (diff) | |
Remove almost unused `flags' argument of suser().
The account flag `ASU' will no longer be set but that makes suser()
mpsafe since it no longer mess with a per-process field.
No objection from millert@, ok tedu@, bluhm@
Diffstat (limited to 'sys/dev/usb')
| -rw-r--r-- | sys/dev/usb/if_umb.c | 4 | ||||
| -rw-r--r-- | sys/dev/usb/ucom.c | 6 | ||||
| -rw-r--r-- | sys/dev/usb/usb.c | 4 |
3 files changed, 7 insertions, 7 deletions
diff --git a/sys/dev/usb/if_umb.c b/sys/dev/usb/if_umb.c index b2571c969df..36b15d3da6d 100644 --- a/sys/dev/usb/if_umb.c +++ b/sys/dev/usb/if_umb.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_umb.c,v 1.17 2017/10/23 15:23:13 gerhard Exp $ */ +/* $OpenBSD: if_umb.c,v 1.18 2018/02/19 08:59:52 mpi Exp $ */ /* * Copyright (c) 2016 genua mbH @@ -698,7 +698,7 @@ umb_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) sizeof (sc->sc_info)); break; case SIOCSUMBPARAM: - if ((error = suser(p, 0)) != 0) + if ((error = suser(p)) != 0) break; if ((error = copyin(ifr->ifr_data, &mp, sizeof (mp))) != 0) break; diff --git a/sys/dev/usb/ucom.c b/sys/dev/usb/ucom.c index 88aa365399c..4e6c9e87583 100644 --- a/sys/dev/usb/ucom.c +++ b/sys/dev/usb/ucom.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ucom.c,v 1.66 2017/12/30 23:08:29 guenther Exp $ */ +/* $OpenBSD: ucom.c,v 1.67 2018/02/19 08:59:52 mpi Exp $ */ /* $NetBSD: ucom.c,v 1.49 2003/01/01 00:10:25 thorpej Exp $ */ /* @@ -469,7 +469,7 @@ ucom_do_open(dev_t dev, int flag, int mode, struct proc *p) SET(tp->t_state, TS_CARR_ON); else CLR(tp->t_state, TS_CARR_ON); - } else if (ISSET(tp->t_state, TS_XCLUDE) && suser(p, 0) != 0) + } else if (ISSET(tp->t_state, TS_XCLUDE) && suser(p) != 0) return (EBUSY); else s = spltty(); @@ -713,7 +713,7 @@ ucom_do_ioctl(struct ucom_softc *sc, u_long cmd, caddr_t data, break; case TIOCSFLAGS: - error = suser(p, 0); + error = suser(p); if (error) break; sc->sc_swflags = *(int *)data; diff --git a/sys/dev/usb/usb.c b/sys/dev/usb/usb.c index a9b530ee65d..0320d153835 100644 --- a/sys/dev/usb/usb.c +++ b/sys/dev/usb/usb.c @@ -1,4 +1,4 @@ -/* $OpenBSD: usb.c,v 1.115 2018/02/03 13:37:37 mpi Exp $ */ +/* $OpenBSD: usb.c,v 1.116 2018/02/19 08:59:52 mpi Exp $ */ /* $NetBSD: usb.c,v 1.77 2003/01/01 00:10:26 thorpej Exp $ */ /* @@ -598,7 +598,7 @@ usbioctl(dev_t devt, u_long cmd, caddr_t data, int flag, struct proc *p) #ifdef USB_DEBUG case USB_SETDEBUG: /* only root can access to these debug flags */ - if ((error = suser(curproc, 0)) != 0) + if ((error = suser(curproc)) != 0) return (error); if (!(flag & FWRITE)) return (EBADF); |