summaryrefslogtreecommitdiff
path: root/sys/net
diff options
context:
space:
mode:
authorMatthew Dempsky <matthew@cvs.openbsd.org>2010-07-20 15:36:04 +0000
committerMatthew Dempsky <matthew@cvs.openbsd.org>2010-07-20 15:36:04 +0000
commitf95bf0159b9d317656e04f36a7b45f5984a04918 (patch)
treead30ebd92f81eada1f3fafedd81cc6fbf3209fa4 /sys/net
parentc423123010a4d3b4ee7bbd318a9d01bad08b80a2 (diff)
Switch some obvious network stack MAC comparisons from bcmp() to
timingsafe_bcmp(). ok deraadt@; committed over WPA.
Diffstat (limited to 'sys/net')
-rw-r--r--sys/net/if_spppsubr.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/net/if_spppsubr.c b/sys/net/if_spppsubr.c
index f2af5381f69..69ee2eeeec2 100644
--- a/sys/net/if_spppsubr.c
+++ b/sys/net/if_spppsubr.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: if_spppsubr.c,v 1.80 2010/05/01 08:14:26 mk Exp $ */
+/* $OpenBSD: if_spppsubr.c,v 1.81 2010/07/20 15:36:03 matthew Exp $ */
/*
* Synchronous PPP/Cisco link level subroutines.
* Keepalive protocol implemented in both Cisco and PPP modes.
@@ -3903,7 +3903,7 @@ sppp_chap_input(struct sppp *sp, struct mbuf *m)
#define SUCCMSG "Welcome!"
if (value_len != sizeof digest ||
- bcmp(digest, value, value_len) != 0) {
+ timingsafe_bcmp(digest, value, value_len) != 0) {
/* action scn, tld */
sppp_auth_send(&chap, sp, CHAP_FAILURE, h->ident,
sizeof(FAILMSG) - 1, (u_char *)FAILMSG,