diff options
author | Visa Hankala <visa@cvs.openbsd.org> | 2018-04-28 03:13:06 +0000 |
---|---|---|
committer | Visa Hankala <visa@cvs.openbsd.org> | 2018-04-28 03:13:06 +0000 |
commit | 356327a519a213c5d0b435c6d4488b3c5f0b3efc (patch) | |
tree | 446ed191773422bb8b098be33ad3b13d10a3c43e /sys/ufs/ext2fs | |
parent | d8f64152dfaaddf25de9dca020b84c322b874855 (diff) |
Clean up the parameters of VOP_LOCK() and VOP_UNLOCK(). It is always
curproc that does the locking or unlocking, so the proc parameter
is pointless and can be dropped.
OK mpi@, deraadt@
Diffstat (limited to 'sys/ufs/ext2fs')
-rw-r--r-- | sys/ufs/ext2fs/ext2fs_inode.c | 4 | ||||
-rw-r--r-- | sys/ufs/ext2fs/ext2fs_lookup.c | 12 | ||||
-rw-r--r-- | sys/ufs/ext2fs/ext2fs_vfsops.c | 8 | ||||
-rw-r--r-- | sys/ufs/ext2fs/ext2fs_vnops.c | 16 |
4 files changed, 20 insertions, 20 deletions
diff --git a/sys/ufs/ext2fs/ext2fs_inode.c b/sys/ufs/ext2fs/ext2fs_inode.c index 714a040d8ca..467a2ccbc56 100644 --- a/sys/ufs/ext2fs/ext2fs_inode.c +++ b/sys/ufs/ext2fs/ext2fs_inode.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ext2fs_inode.c,v 1.58 2016/03/19 12:04:16 natano Exp $ */ +/* $OpenBSD: ext2fs_inode.c,v 1.59 2018/04/28 03:13:05 visa Exp $ */ /* $NetBSD: ext2fs_inode.c,v 1.24 2001/06/19 12:59:18 wiz Exp $ */ /* @@ -132,7 +132,7 @@ ext2fs_inactive(void *v) ext2fs_update(ip, 0); } out: - VOP_UNLOCK(vp, p); + VOP_UNLOCK(vp); /* * If we are done with the inode, reclaim it * so that it can be reused immediately. diff --git a/sys/ufs/ext2fs/ext2fs_lookup.c b/sys/ufs/ext2fs/ext2fs_lookup.c index 6e17fdeaa03..6f90182b61b 100644 --- a/sys/ufs/ext2fs/ext2fs_lookup.c +++ b/sys/ufs/ext2fs/ext2fs_lookup.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ext2fs_lookup.c,v 1.42 2016/03/19 12:04:16 natano Exp $ */ +/* $OpenBSD: ext2fs_lookup.c,v 1.43 2018/04/28 03:13:05 visa Exp $ */ /* $NetBSD: ext2fs_lookup.c,v 1.16 2000/08/03 20:29:26 thorpej Exp $ */ /* @@ -429,7 +429,7 @@ searchloop: */ cnp->cn_flags |= SAVENAME; if (!lockparent) { - VOP_UNLOCK(vdp, p); + VOP_UNLOCK(vdp); cnp->cn_flags |= PDIRUNLOCK; } return (EJUSTRETURN); @@ -512,7 +512,7 @@ found: } *vpp = tdp; if (!lockparent) { - VOP_UNLOCK(vdp, p); + VOP_UNLOCK(vdp); cnp->cn_flags |= PDIRUNLOCK; } return (0); @@ -538,7 +538,7 @@ found: *vpp = tdp; cnp->cn_flags |= SAVENAME; if (!lockparent) { - VOP_UNLOCK(vdp, p); + VOP_UNLOCK(vdp); cnp->cn_flags |= PDIRUNLOCK; } return (0); @@ -565,7 +565,7 @@ found: */ pdp = vdp; if (flags & ISDOTDOT) { - VOP_UNLOCK(pdp, p); /* race to get the inode */ + VOP_UNLOCK(pdp); /* race to get the inode */ cnp->cn_flags |= PDIRUNLOCK; if ((error = VFS_VGET(vdp->v_mount, dp->i_ino, &tdp)) != 0) { if (vn_lock(pdp, LK_EXCLUSIVE | LK_RETRY, p) == 0) @@ -587,7 +587,7 @@ found: if ((error = VFS_VGET(vdp->v_mount, dp->i_ino, &tdp)) != 0) return (error); if (!lockparent || !(flags & ISLASTCN)) { - VOP_UNLOCK(pdp, p); + VOP_UNLOCK(pdp); cnp->cn_flags |= PDIRUNLOCK; } *vpp = tdp; diff --git a/sys/ufs/ext2fs/ext2fs_vfsops.c b/sys/ufs/ext2fs/ext2fs_vfsops.c index 84c9305b1c0..754263e598d 100644 --- a/sys/ufs/ext2fs/ext2fs_vfsops.c +++ b/sys/ufs/ext2fs/ext2fs_vfsops.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ext2fs_vfsops.c,v 1.104 2018/03/28 09:37:42 mpi Exp $ */ +/* $OpenBSD: ext2fs_vfsops.c,v 1.105 2018/04/28 03:13:05 visa Exp $ */ /* $NetBSD: ext2fs_vfsops.c,v 1.1 1997/06/11 09:34:07 bouyer Exp $ */ /* @@ -572,7 +572,7 @@ out: brelse(bp); vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY, p); (void)VOP_CLOSE(devvp, ronly ? FREAD : FREAD|FWRITE, cred, p); - VOP_UNLOCK(devvp, p); + VOP_UNLOCK(devvp); if (ump) { free(ump->um_e2fs, M_UFSMNT, sizeof *ump->um_e2fs); free(ump, M_UFSMNT, sizeof *ump); @@ -641,7 +641,7 @@ ext2fs_flushfiles(struct mount *mp, int flags, struct proc *p) */ vn_lock(ump->um_devvp, LK_EXCLUSIVE | LK_RETRY, p); error = VOP_FSYNC(ump->um_devvp, p->p_ucred, MNT_WAIT, p); - VOP_UNLOCK(ump->um_devvp, p); + VOP_UNLOCK(ump->um_devvp); return (error); } @@ -780,7 +780,7 @@ ext2fs_sync(struct mount *mp, int waitfor, int stall, vn_lock(ump->um_devvp, LK_EXCLUSIVE | LK_RETRY, p); if ((error = VOP_FSYNC(ump->um_devvp, cred, waitfor, p)) != 0) allerror = error; - VOP_UNLOCK(ump->um_devvp, p); + VOP_UNLOCK(ump->um_devvp); } /* * Write back modified superblock. diff --git a/sys/ufs/ext2fs/ext2fs_vnops.c b/sys/ufs/ext2fs/ext2fs_vnops.c index 9a795ff81b4..f40cf7d5ff1 100644 --- a/sys/ufs/ext2fs/ext2fs_vnops.c +++ b/sys/ufs/ext2fs/ext2fs_vnops.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ext2fs_vnops.c,v 1.79 2018/01/08 16:15:34 millert Exp $ */ +/* $OpenBSD: ext2fs_vnops.c,v 1.80 2018/04/28 03:13:05 visa Exp $ */ /* $NetBSD: ext2fs_vnops.c,v 1.1 1997/06/11 09:34:09 bouyer Exp $ */ /* @@ -477,7 +477,7 @@ ext2fs_link(void *v) pool_put(&namei_pool, cnp->cn_pnbuf); out1: if (dvp != vp) - VOP_UNLOCK(vp, p); + VOP_UNLOCK(vp); out2: vput(dvp); return (error); @@ -585,13 +585,13 @@ abortit: dp = VTOI(fdvp); ip = VTOI(fvp); if ((nlink_t)ip->i_e2fs_nlink >= LINK_MAX) { - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); error = EMLINK; goto abortit; } if ((ip->i_e2fs_flags & (EXT2_IMMUTABLE | EXT2_APPEND)) || (dp->i_e2fs_flags & EXT2_APPEND)) { - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); error = EPERM; goto abortit; } @@ -601,7 +601,7 @@ abortit: error = VOP_ACCESS(tvp, VWRITE, tcnp->cn_cred, tcnp->cn_proc); if (error) { - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); error = EACCES; goto abortit; } @@ -613,7 +613,7 @@ abortit: (fcnp->cn_flags&ISDOTDOT) || (tcnp->cn_flags & ISDOTDOT) || (ip->i_flag & IN_RENAME)) { - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); error = EINVAL; goto abortit; } @@ -641,7 +641,7 @@ abortit: ip->i_e2fs_nlink++; ip->i_flag |= IN_CHANGE; if ((error = ext2fs_update(ip, 1)) != 0) { - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); goto bad; } @@ -656,7 +656,7 @@ abortit: * call to checkpath(). */ error = VOP_ACCESS(fvp, VWRITE, tcnp->cn_cred, tcnp->cn_proc); - VOP_UNLOCK(fvp, p); + VOP_UNLOCK(fvp); if (oldparent != dp->i_number) newparent = dp->i_number; if (doingdirectory && newparent) { |