diff options
author | David Gwynne <dlg@cvs.openbsd.org> | 2015-01-27 03:17:38 +0000 |
---|---|---|
committer | David Gwynne <dlg@cvs.openbsd.org> | 2015-01-27 03:17:38 +0000 |
commit | 7ac4ce62e2476f05331d3c5341c866ed14b81a70 (patch) | |
tree | 21042b557424b93c264a0a6a7e93f1512d1351c8 /sys/uvm | |
parent | c2499bdb5b4f1bd235843fb845b156cfeae25b83 (diff) |
remove the second void * argument on tasks.
when workqs were introduced, we provided a second argument so you
could pass a thing and some context to work on it in. there were
very few things that took advantage of the second argument, so when
i introduced pools i suggested removing it. since tasks were meant
to replace workqs, it was requested that we keep the second argument
to make porting from workqs to tasks easier.
now that workqs are gone, i had a look at the use of the second
argument again and found only one good use of it (vdsp(4) on sparc64
if you're interested) and a tiny handful of questionable uses. the
vast majority of tasks only used a single argument. i have since
modified all tasks that used two args to only use one, so now we
can remove the second argument.
so this is a mechanical change. all tasks only passed NULL as their
second argument, so we can just remove it.
ok krw@
Diffstat (limited to 'sys/uvm')
-rw-r--r-- | sys/uvm/uvm_swap.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/uvm/uvm_swap.c b/sys/uvm/uvm_swap.c index da3367f2605..c0df4e59649 100644 --- a/sys/uvm/uvm_swap.c +++ b/sys/uvm/uvm_swap.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uvm_swap.c,v 1.133 2015/01/13 02:24:26 dlg Exp $ */ +/* $OpenBSD: uvm_swap.c,v 1.134 2015/01/27 03:17:37 dlg Exp $ */ /* $NetBSD: uvm_swap.c,v 1.40 2000/11/17 11:39:39 mrg Exp $ */ /* @@ -231,7 +231,7 @@ int swap_off(struct proc *, struct swapdev *); void sw_reg_strategy(struct swapdev *, struct buf *, int); void sw_reg_iodone(struct buf *); -void sw_reg_iodone_internal(void *, void *); +void sw_reg_iodone_internal(void *); void sw_reg_start(struct swapdev *); int uvm_swap_io(struct vm_page **, int, int, int); @@ -1231,7 +1231,7 @@ sw_reg_strategy(struct swapdev *sdp, struct buf *bp, int bn) /* patch it back to the vnx */ nbp->vb_vnx = vnx; - task_set(&nbp->vb_task, sw_reg_iodone_internal, nbp, NULL); + task_set(&nbp->vb_task, sw_reg_iodone_internal, nbp); s = splbio(); if (vnx->vx_error != 0) { @@ -1315,7 +1315,7 @@ sw_reg_iodone(struct buf *bp) } void -sw_reg_iodone_internal(void *xvbp, void *null) +sw_reg_iodone_internal(void *xvbp) { struct vndbuf *vbp = xvbp; struct vndxfer *vnx = vbp->vb_vnx; |