asprintf returns -1, not an arbitrary value < 0. Also upon error the

(very sloppy specification) leaves an undefined value in *ret, so it is
wrong to inspect it, the error condition is enough.
discussed a little with nicm, and then much more with millert until we
were exasperated

1 files changed, 1 insertions, 1 deletions

diff --git a/usr.bin/less/main.c b/usr.bin/less/main.c
index 5fc7f131803..9820eb5903f 100644
--- a/usr.bin/less/main.c
+++ b/usr.bin/less/main.c
@@ -303,7 +303,7 @@ easprintf(const char *fmt, ...)
 	rv = vasprintf(&p, fmt, ap);
 	va_end(ap);
 
-	if (p == NULL || rv < 0) {
+	if (rv == -1) {
 		error("Cannot allocate memory", NULL);
 		quit(QUIT_ERROR);
 	}