summaryrefslogtreecommitdiff
path: root/usr.sbin/ypldap
diff options
context:
space:
mode:
authorMartijn van Duren <martijn@cvs.openbsd.org>2022-03-31 09:06:56 +0000
committerMartijn van Duren <martijn@cvs.openbsd.org>2022-03-31 09:06:56 +0000
commitcd554ab6dc926c2ef025ba703734d9df4559b9fc (patch)
tree66f96fbc3f7f3d3643834c02febb3cc3647b4efc /usr.sbin/ypldap
parent87c483ca71e0c106cfceec38d420f8b87d9dc5dd (diff)
'e' is no longer an optional element for ober_scanf_elements.
This caused the last attribute to be dropped. Reported by Allan Streib (astreib <at> fastmail <dot> fm) Reminded by Raf Czlonka (rczlonka <at> gmail <dot> com) OK tb@ claudio@
Diffstat (limited to 'usr.sbin/ypldap')
-rw-r--r--usr.sbin/ypldap/aldap.c13
1 files changed, 6 insertions, 7 deletions
diff --git a/usr.sbin/ypldap/aldap.c b/usr.sbin/ypldap/aldap.c
index 3186f7d94bb..c72547af96b 100644
--- a/usr.sbin/ypldap/aldap.c
+++ b/usr.sbin/ypldap/aldap.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: aldap.c,v 1.47 2019/10/24 12:39:27 tb Exp $ */
+/* $OpenBSD: aldap.c,v 1.48 2022/03/31 09:06:55 martijn Exp $ */
/*
* Copyright (c) 2008 Alexander Schrijver <aschrijver@openbsd.org>
@@ -580,15 +580,15 @@ int
aldap_first_attr(struct aldap_message *msg, char **outkey,
struct aldap_stringset **outvalues)
{
- struct ber_element *b, *c;
+ struct ber_element *b;
char *key;
struct aldap_stringset *ret;
if (msg->body.search.attrs == NULL)
goto fail;
- if (ober_scanf_elements(msg->body.search.attrs, "{s(e)}e",
- &key, &b, &c) != 0)
+ if (ober_scanf_elements(msg->body.search.attrs, "{s(e)}",
+ &key, &b) != 0)
goto fail;
msg->body.search.iter = msg->body.search.attrs->be_next;
@@ -610,7 +610,7 @@ int
aldap_next_attr(struct aldap_message *msg, char **outkey,
struct aldap_stringset **outvalues)
{
- struct ber_element *a, *b;
+ struct ber_element *a;
char *key;
struct aldap_stringset *ret;
@@ -622,8 +622,7 @@ aldap_next_attr(struct aldap_message *msg, char **outkey,
if (ober_get_eoc(msg->body.search.iter) == 0)
goto notfound;
- if (ober_scanf_elements(msg->body.search.iter, "{s(e)}e", &key, &a, &b)
- != 0)
+ if (ober_scanf_elements(msg->body.search.iter, "{s(e)}", &key, &a) != 0)
goto fail;
msg->body.search.iter = msg->body.search.iter->be_next;