diff options
| author | brian <brian@cvs.openbsd.org> | 2001-08-18 19:34:34 +0000 |
|---|---|---|
| committer | brian <brian@cvs.openbsd.org> | 2001-08-18 19:34:34 +0000 |
| commit | 3cb7084ef30e92b3858c31b6fb7fff891e8ea3bf (patch) | |
| tree | 2289a2f032369bd7a4ffad97374edfc3df6fa27f /usr.sbin | |
| parent | b728c67f4a10e177d3abd254bc75e4faf89b6de9 (diff) | |
Fix a possible buffer overflow; theo
Diffstat (limited to 'usr.sbin')
| -rw-r--r-- | usr.sbin/ppp/ppp/command.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/usr.sbin/ppp/ppp/command.c b/usr.sbin/ppp/ppp/command.c index b34dd5c8c20..3c0880b76a8 100644 --- a/usr.sbin/ppp/ppp/command.c +++ b/usr.sbin/ppp/ppp/command.c @@ -25,7 +25,7 @@ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * - * $OpenBSD: command.c,v 1.65 2001/07/26 11:36:51 brian Exp $ + * $OpenBSD: command.c,v 1.66 2001/08/18 19:34:33 brian Exp $ */ #include <sys/param.h> @@ -250,14 +250,14 @@ HelpCommand(struct cmdargs const *arg) static int IdentCommand(struct cmdargs const *arg) { - int f, pos; + int f, max, pos; *arg->cx->physical->link.lcp.cfg.ident = '\0'; + max = sizeof arg->cx->physical->link.lcp.cfg.ident; - for (pos = 0, f = arg->argn; f < arg->argc; f++) - pos += snprintf(arg->cx->physical->link.lcp.cfg.ident + pos, - sizeof arg->cx->physical->link.lcp.cfg.ident - pos, "%s%s", - f == arg->argn ? "" : " ", arg->argv[f]); + for (pos = 0, f = arg->argn; f < arg->argc && pos < max; f++) + pos += snprintf(arg->cx->physical->link.lcp.cfg.ident + pos, max - pos, + "%s%s", f == arg->argn ? "" : " ", arg->argv[f]); return 0; } |