diff options
| author | Claudio Jeker <claudio@cvs.openbsd.org> | 2024-01-25 11:13:36 +0000 |
|---|---|---|
| committer | Claudio Jeker <claudio@cvs.openbsd.org> | 2024-01-25 11:13:36 +0000 |
| commit | e7ac21666ead76904c59d244b9e3fecc17284288 (patch) | |
| tree | acabed2df9b8e8e4c66e884e10e210f587f16c76 /usr.sbin | |
| parent | dce6402bf9a9986b34c94af128110f9914177595 (diff) | |
Use RFC7606 treat-as-withdraw for ORIGIN attributes with an invalid value.
OK tb@
Diffstat (limited to 'usr.sbin')
| -rw-r--r-- | usr.sbin/bgpd/rde.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/usr.sbin/bgpd/rde.c b/usr.sbin/bgpd/rde.c index 21526c4efe4..c357ea67a03 100644 --- a/usr.sbin/bgpd/rde.c +++ b/usr.sbin/bgpd/rde.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rde.c,v 1.618 2024/01/25 09:46:12 claudio Exp $ */ +/* $OpenBSD: rde.c,v 1.619 2024/01/25 11:13:35 claudio Exp $ */ /* * Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org> @@ -1983,8 +1983,14 @@ rde_attr_parse(struct ibuf *buf, struct rde_peer *peer, if (ibuf_get_n8(&attrbuf, &a->origin) == -1) goto bad_len; if (a->origin > ORIGIN_INCOMPLETE) { - rde_update_err(peer, ERR_UPDATE, ERR_UPD_ORIGIN, - &attrbuf); + /* + * mark update as bad and withdraw all routes as per + * RFC 7606 + */ + a->flags |= F_ATTR_PARSE_ERR; + log_peer_warnx(&peer->conf, "bad ORIGIN %u, " + "path invalidated and prefix withdrawn", + a->origin); return (-1); } a->flags |= F_ATTR_ORIGIN; |