Age | Commit message (Collapse) | Author |
|
mount_mfs(8) no monger mounts "/build" with the following fstab(5) entry:
/dev/sd0b /build mfs rw,noperm,nodev,nosuid,-s=2064348,noauto
as found out by bluhm the hard way.
|
|
If the requested path contained a slash, opendev(3) blindly opened the file
and returned a file descriptor to it.
Check for block or character devices (according to OPENDEV_BLCK) and fail
for other types.
Spotted through installboot(8) which happily opened a stage file as device
when forgetting the device argument:
# installboot -v ./biosboot
Using / as root
installing bootstrap on ./biosboot
using first-stage /usr/mdec/biosboot, second-stage /usr/mdec/boot
installboot: disklabel: ./biosboot: Inappropriate ioctl for device
This makes it fail earlier, as expected:
# installboot -v ./biosboot
installboot: open: ./biosboot: Block device required
The case where opendev(3) is passed a string not containing a slash, i.e.
a supposed DUID, is fine, as diskmap(4) will ensure that only valid device
paths are returned, if the DUID is valid.
Feedback OK millert
|
|
|
|
|
|
ok jmc@ jsing@
|
|
|
|
|
|
|
|
|
|
o) always close .Bl tags;
o) fix usage of .Xr;
millert@ ok
|
|
o) remove extra space in the end of line;
o) remove extra blank lines in the end of file;
o) remove .Pp before .Ss;
o) CAVEAT -> CAVEATS;
o) fix usage of .Fa;
o) <blank-line> -> .Pp;
o) wrap long lines;
millert@ ok
|
|
|
|
|
|
will be overwritten by subsequent calls; suggested by pjanzen, ok millert
|
|
|
|
device is opened by default).
Don't open the file w/o adding a /dev/ prefix unless the file has
a '/' in it. This prevents problems where someone says "disklabel
sd0" with a file called "sd0" in the cwd.
The OPENDEV_DRCT flag has been deprecated as it is the the default
behavior and always has been.
Add checks for >= MAXPATHLEN and return ENAMETOOLONG in that case.
|
|
Out of the approximately 1450 man pages, only about 90 of them were wrong.
Thanks to kwesterback@home.com for coming up with a script and patch to repair
this. The patch also inserted a .Os macro in the few man pages that were
missing one.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|