Age | Commit message (Collapse) | Author |
|
Add missing error checks to all calls under sbin/
Input kettenis, millert
OK millert
|
|
optimization. As observed by ali_farzanrad(at)riseup.net, support
for these was broken in the 5.5 release in early 2014 by the time_t
changes. No one noticed before now, so clearly this isn't something
we need to continue to support; rejecting in ffs_validate() is an
improvement.
Also: simplify DIRSIZ(), drop OLDDIRFMT and NEWDIRFMT, tests of
fs_maxsymlinklen against zero, #ifdef tests of FS_44INODEFMT, and
remove support for newfs -O0, last used in 2016.
ok miod@
|
|
ok miod@ millert@
|
|
jmc@ dislikes a comma before "then" in a conditional, so leave those
untouched.
ok jmc@
|
|
3rd (variadic) mode_t parameter is irrelevant. Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef.
ok millert
|
|
Largely following the commit by mckusick in FreeBSD.
ok naddy@
|
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
ok deraadt@
|
|
"warning:" rectification.
|
|
so gcc doesn't complain about defining but not using them.
typo correction & ok jca@
|
|
|
|
ok mglocker
|
|
correctly - logically complete that now by removing MLINKS from base;
authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;
ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
|
|
|
|
|
|
ok millert@
|
|
ok millert@ deraadt@
|
|
delete <sys/param.h> if now possible
ok guenther
|
|
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
|
|
|
|
Casting from long to int for a size_t argument is dumb.
Calling warnx() right before err() is silly.
ok millert@
|
|
ok krw@
|
|
being-standardized <endian.h>
ok deraadt@ millert@ beck@
|
|
the errno of an intervening cleanup operation like close/unlink/etc.
Diff from Doug Hogan (doug (at) acyclic.org)
|
|
|
|
from Loganaden Velvindron
|
|
|
|
From: Jan Stary
|
|
|
|
ok tedu otto
|
|
ok otto
|
|
issue noted by Ronald F. Guilmette, freebsd docs/176648
|
|
|
|
ok krw@
|
|
|
|
|
|
|
|
unmaintainable). these days, people use source. these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms
|
|
32K). This allows the automatic recognition of dumps written with
64K buffers. It also prevents alert scsi devices from complaining
about read requests that provide only 1/2 the room needed for an
actual tape record.
Problem noted, fix tested & ok henning@
|
|
with help and ok ray@
|
|
use sizeof input intead of BUFSIZ
remove unneeded feof
handle empty strings returned by fgets
properly remove newline and white space at the end of buffer
with help and ok ray@
|
|
use strtonum instead of atoi
prompted by ray@
ok moritz@ ray@
|
|
use sizeof buf instead of TP_BSIZE
use strcspn to properly overwrite '\n' in fgets returned buffer
ok moritz@ ray@
|
|
|
|
With help from otto@
|
|
|
|
|
|
- use /dev/sd rather than /dev/rp, since rp no longer exists
- use rst0 instead of rst8, since rst8 does not exist (by default)
from Matthias Scheler
ok otto
|
|
|
|
|