summaryrefslogtreecommitdiff
path: root/usr.bin/talk
AgeCommit message (Collapse)Author
2019-06-28When system calls indicate an error they return -1, not some arbitraryTheo de Raadt
value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
2017-05-25incompatibilities with 4.2 are no longer interestingTed Unangst
2016-03-16More "(<blah> *)0" -> NULL, avoiding any stdarg functions.Kenneth R Westerback
Feedback millert@ kettenis@
2016-03-08Actually enforce what was done on rev 1.11:mestre
if one of the parties is remote it needs to pledge for inet
2016-02-18finish conversion select -> poll, error messages count too, sloppy theo.Marc Espie
okay millert@
2016-02-05pledge(2) for talk(1):mestre
At the beginning the largest pledge is the following: rpath: read ~/.terminfo (the reason was changed pointed out by semarie@) inet/dns: talk may need to connect to a remote host and resolve it getpw: if getlogin(2) fails then it needs getpwuid(3) as a fallback tty: this is a typical tty application, so it'll always need this annotation Then just before the application main loop check if the talk is with local user so it only needs "stdio tty", if it's remote then it needs "stdio inet tty". I couldn't test this with a remote host to confirm if it needs inet or not but as per jca@'s comment "tighter settings - if possible - can happen later" ok jca@ and also discussed with tb@
2016-02-01Remove unused headers and sort the remainingmestre
Remove lint-style comments Swap hardcoded string on usage() for __progname OK tb@
2015-01-16Replace <sys/param.h> with <limits.h> and other less dirty headers whereTheo de Raadt
possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
2014-06-02- document SIGINT, because of its zero return valueJason McIntyre
- \*Gt -> >, as recommended by schwarze ok guenther
2013-12-11remove unused include dating from the pre-termios code and accidentallyChristian Weisgerber
reintroduced with the 4.4lite merge 19 years ago
2013-11-28unsigned char for ctypeTheo de Raadt
ok krw okan
2013-03-11handle ECONNABORTED errors from accept(). In many code blocks they can beTheo de Raadt
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are. ok's from various maintainers of these directories...
2010-10-28more roff adjustments;Jason McIntyre
2010-10-21more EXIT STATUS bits; from Daniel DickmanJason McIntyre
2010-08-12some inconsequential cleanups. ok deraadtTed Unangst
2009-10-28rcsid[] and sccsid[] and copyright[] are essentially unmaintained (andTheo de Raadt
unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
2009-05-09remove unused functionCharles Longeau
from tobias@ "just delete them" tedu@, ok millert@ tobias@
2009-02-10STANDARDS:Jason McIntyre
mark these utilities as being either optional (SD/FR/UP); or as being compliant only with XPG4 (XSI); strip.1 and talk.1 are tweaked purely for consistency; thanks otto for feedback
2009-02-08bump the posix reference in STANDARDS to IEEE Std 1003.1-2008, with a fewJason McIntyre
updates to follow;
2008-05-31synchronize usage and synopsis.Igor Sobrado
2007-05-31convert to new .Dd format;Jason McIntyre
2007-05-31- note some apps which are xpg4, not posixJason McIntyre
- note that some apps are optional to posix after some discussion w/ otto
2007-05-25"interupt" -> "interrupt" in various comments. Mostly from Diego Casati.Kenneth R Westerback
2006-10-29Plug a mem leak. Found in one of my trees. Forgat where it came from; mostOtto Moerbeek
likely from a NetBSD Coverity fix. ok ray@
2005-04-13use STD{IN,OUT,ERR}_FILENOTheo de Raadt
2004-08-04.Xr talkd 8; from Scott Francis (PR #3884);Jason McIntyre
kill a .Pp/-compact combination in a display whilst here;
2004-03-16errno is not specified to be int, but something from errno.h. ok millert@Ted Unangst
2004-03-02use socklen_t and better socket() checks. from Andrey MatveevTed Unangst
-Wall for good measure
2003-10-01handle failed strdup; reported by jjy2+@pitt.eduTheo de Raadt
2003-09-26retry for ECONNABORTED tooTheo de Raadt
2003-08-11use poll to replace the fd_set overflows. some input from fgsch; millert okTheo de Raadt
2003-07-10add missing includesDavid Krause
ok deraadt@ tedu@
2003-06-10mostly ansi cleanup; pval okTheo de Raadt
2003-06-10- section reorderJason McIntyre
- COMPATIBILITY merge - macro cleanup - kill whitespace at EOL - new sentence, new line ssh pages ok markus@
2003-06-03Remove the advertising clause in the UCB license which BerkeleyTodd C. Miller
rescinded 22 July 1999. Proofed by myself and Theo.
2003-01-09spelling; from jmc at prioris dot mini dot pw dot edu dot pl.Federico G. Schwindt
2002-11-14use $ or # before commands in examplesTheo de Raadt
2002-06-21o Resize nicely when we receive SIGWINCHTodd C. Miller
o Also change some 0-2 to *_FILENO
2002-06-20Add a -s option to enable the smooth scrolling in revision 1.10Todd C. Miller
The default behavior remains unchanged.
2002-06-20undo last commit; deraadt@Oleg Safiullin
2002-06-20scrolling support.Oleg Safiullin
ok millert@
2002-06-02KNFTheo de Raadt
2002-02-16Part one of userland __P removal. Done with a simple regexp with some minor ↵Todd C. Miller
hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
2001-11-19kill more registersMike Pechkin
millert@ ok
2001-09-05select for a more accurate size; millert okTheo de Raadt
2001-07-17-Wall cleanup; ok deraadtPeter Valchev
2001-03-09exit(-#) is wrongTheo de Raadt
2000-12-31Redress PR 1547. Provide an option to pass high characters withoutHugh Graham
escaping, and turn it off by default. Checked by angelos@.
2000-12-30Allow printing characters > 0x80, thus permitting other charsetsAngelos D. Keromytis
(dem0n@istc.kiev.ua, PR 1547)
2000-06-30warnx?/errx? paranoia (use "%s" not a bare string unless it is aTodd C. Miller
constant). These are not security holes but it is worth fixing them anyway both for robustness and so folks looking for examples in the tree are not misled into doing something potentially dangerous. Furthermore, it is a bad idea to assume that pathnames will not include '%' in them and that error routines don't return strings with '%' in them (especially in light of the possibility of locales).