1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
|
/* $OpenBSD: validate.c,v 1.62 2023/05/23 06:42:08 tb Exp $ */
/*
* Copyright (c) 2019 Kristaps Dzonsons <kristaps@bsd.lv>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <arpa/inet.h>
#include <assert.h>
#include <ctype.h>
#include <err.h>
#include <fcntl.h>
#include <inttypes.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#include "extern.h"
extern ASN1_OBJECT *certpol_oid;
/*
* Walk up the chain of certificates trying to match our AS number to
* one of the allocations in that chain.
* Returns 1 if covered or 0 if not.
*/
static int
valid_as(struct auth *a, uint32_t min, uint32_t max)
{
int c;
if (a == NULL)
return 0;
/* Does this certificate cover our AS number? */
c = as_check_covered(min, max, a->cert->as, a->cert->asz);
if (c > 0)
return 1;
else if (c < 0)
return 0;
/* If it inherits, walk up the chain. */
return valid_as(a->parent, min, max);
}
/*
* Walk up the chain of certificates (really just the last one, but in
* the case of inheritance, the ones before) making sure that our IP
* prefix is covered in the first non-inheriting specification.
* Returns 1 if covered or 0 if not.
*/
static int
valid_ip(struct auth *a, enum afi afi,
const unsigned char *min, const unsigned char *max)
{
int c;
if (a == NULL)
return 0;
/* Does this certificate cover our IP prefix? */
c = ip_addr_check_covered(afi, min, max, a->cert->ips, a->cert->ipsz);
if (c > 0)
return 1;
else if (c < 0)
return 0;
/* If it inherits, walk up the chain. */
return valid_ip(a->parent, afi, min, max);
}
/*
* Make sure the AKI is the same as the AKI listed on the Manifest,
* and that the SKI doesn't already exist.
* Return the parent by its AKI, or NULL on failure.
*/
struct auth *
valid_ski_aki(const char *fn, struct auth_tree *auths,
const char *ski, const char *aki, const char *mftaki)
{
struct auth *a;
if (mftaki != NULL) {
if (strcmp(aki, mftaki) != 0) {
warnx("%s: AKI doesn't match Manifest AKI", fn);
return NULL;
}
}
if (auth_find(auths, ski) != NULL) {
warnx("%s: RFC 6487: duplicate SKI", fn);
return NULL;
}
a = auth_find(auths, aki);
if (a == NULL)
warnx("%s: RFC 6487: unknown AKI", fn);
return a;
}
/*
* Validate a trust anchor by making sure that the SKI is unique.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_ta(const char *fn, struct auth_tree *auths, const struct cert *cert)
{
/* SKI must not be a dupe. */
if (auth_find(auths, cert->ski) != NULL) {
warnx("%s: RFC 6487: duplicate SKI", fn);
return 0;
}
return 1;
}
/*
* Validate a non-TA certificate: make sure its IP and AS resources are
* fully covered by those in the authority key (which must exist).
* Returns 1 if valid, 0 otherwise.
*/
int
valid_cert(const char *fn, struct auth *a, const struct cert *cert)
{
size_t i;
uint32_t min, max;
char buf1[64], buf2[64];
for (i = 0; i < cert->asz; i++) {
if (cert->as[i].type == CERT_AS_INHERIT)
continue;
min = cert->as[i].type == CERT_AS_ID ?
cert->as[i].id : cert->as[i].range.min;
max = cert->as[i].type == CERT_AS_ID ?
cert->as[i].id : cert->as[i].range.max;
if (valid_as(a, min, max))
continue;
warnx("%s: RFC 6487: uncovered AS: "
"%u--%u", fn, min, max);
return 0;
}
for (i = 0; i < cert->ipsz; i++) {
if (cert->ips[i].type == CERT_IP_INHERIT)
continue;
if (valid_ip(a, cert->ips[i].afi, cert->ips[i].min,
cert->ips[i].max))
continue;
switch (cert->ips[i].type) {
case CERT_IP_RANGE:
ip_addr_print(&cert->ips[i].range.min,
cert->ips[i].afi, buf1, sizeof(buf1));
ip_addr_print(&cert->ips[i].range.max,
cert->ips[i].afi, buf2, sizeof(buf2));
warnx("%s: RFC 6487: uncovered IP: "
"%s--%s", fn, buf1, buf2);
break;
case CERT_IP_ADDR:
ip_addr_print(&cert->ips[i].ip,
cert->ips[i].afi, buf1, sizeof(buf1));
warnx("%s: RFC 6487: uncovered IP: "
"%s", fn, buf1);
break;
case CERT_IP_INHERIT:
warnx("%s: RFC 6487: uncovered IP: "
"(inherit)", fn);
break;
}
return 0;
}
return 1;
}
/*
* Validate our ROA: check that the prefixes (ipAddrBlocks) are contained.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_roa(const char *fn, struct cert *cert, struct roa *roa)
{
size_t i;
char buf[64];
for (i = 0; i < roa->ipsz; i++) {
if (ip_addr_check_covered(roa->ips[i].afi, roa->ips[i].min,
roa->ips[i].max, cert->ips, cert->ipsz) > 0)
continue;
ip_addr_print(&roa->ips[i].addr, roa->ips[i].afi, buf,
sizeof(buf));
warnx("%s: RFC 6482: uncovered IP: %s", fn, buf);
return 0;
}
return 1;
}
/*
* Validate a file by verifying the SHA256 hash of that file.
* The file to check is passed as a file descriptor.
* Returns 1 if hash matched, 0 otherwise. Closes fd when done.
*/
int
valid_filehash(int fd, const char *hash, size_t hlen)
{
SHA256_CTX ctx;
char filehash[SHA256_DIGEST_LENGTH];
char buffer[8192];
ssize_t nr;
if (hlen != sizeof(filehash))
errx(1, "bad hash size");
if (fd == -1)
return 0;
SHA256_Init(&ctx);
while ((nr = read(fd, buffer, sizeof(buffer))) > 0)
SHA256_Update(&ctx, buffer, nr);
close(fd);
SHA256_Final(filehash, &ctx);
if (memcmp(hash, filehash, sizeof(filehash)) != 0)
return 0;
return 1;
}
/*
* Same as above but with a buffer instead of a fd.
*/
int
valid_hash(unsigned char *buf, size_t len, const char *hash, size_t hlen)
{
char filehash[SHA256_DIGEST_LENGTH];
if (hlen != sizeof(filehash))
errx(1, "bad hash size");
if (buf == NULL || len == 0)
return 0;
if (!EVP_Digest(buf, len, filehash, NULL, EVP_sha256(), NULL))
errx(1, "EVP_Digest failed");
if (memcmp(hash, filehash, sizeof(filehash)) != 0)
return 0;
return 1;
}
/*
* Validate that a filename only contains characters from the POSIX portable
* filename character set [A-Za-z0-9._-], see IEEE Std 1003.1-2013, 3.278.
*/
int
valid_filename(const char *fn, size_t len)
{
const unsigned char *c;
size_t i;
for (c = fn, i = 0; i < len; i++, c++)
if (!isalnum(*c) && *c != '-' && *c != '_' && *c != '.')
return 0;
return 1;
}
/*
* Validate a URI to make sure it is pure ASCII and does not point backwards
* or doing some other silly tricks. To enforce the protocol pass either
* https:// or rsync:// as proto, if NULL is passed no protocol is enforced.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_uri(const char *uri, size_t usz, const char *proto)
{
size_t s;
if (usz > MAX_URI_LENGTH)
return 0;
for (s = 0; s < usz; s++)
if (!isalnum((unsigned char)uri[s]) &&
!ispunct((unsigned char)uri[s]))
return 0;
if (proto != NULL) {
s = strlen(proto);
if (s >= usz)
return 0;
if (strncasecmp(uri, proto, s) != 0)
return 0;
}
/* do not allow files or directories to start with a '.' */
if (strstr(uri, "/.") != NULL)
return 0;
return 1;
}
/*
* Validate that a URI has the same host as the URI passed in proto.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_origin(const char *uri, const char *proto)
{
const char *to;
/* extract end of host from proto URI */
to = strstr(proto, "://");
if (to == NULL)
return 0;
to += strlen("://");
if ((to = strchr(to, '/')) == NULL)
return 0;
/* compare hosts including the / for the start of the path section */
if (strncasecmp(uri, proto, to - proto + 1) != 0)
return 0;
return 1;
}
/*
* Walk the tree of known valid CA certificates until we find a certificate that
* doesn't inherit. Build a chain of intermediates and use the non-inheriting
* certificate as a trusted root by virtue of X509_V_FLAG_PARTIAL_CHAIN. The
* RFC 3779 path validation needs a non-inheriting trust root to ensure that
* all delegated resources are covered.
*/
static void
build_chain(const struct auth *a, STACK_OF(X509) **intermediates,
STACK_OF(X509) **root)
{
*intermediates = NULL;
*root = NULL;
if (a == NULL)
return;
if ((*intermediates = sk_X509_new_null()) == NULL)
err(1, "sk_X509_new_null");
if ((*root = sk_X509_new_null()) == NULL)
err(1, "sk_X509_new_null");
for (; a != NULL; a = a->parent) {
assert(a->cert->x509 != NULL);
if (!a->any_inherits) {
if (!sk_X509_push(*root, a->cert->x509))
errx(1, "sk_X509_push");
break;
}
if (!sk_X509_push(*intermediates, a->cert->x509))
errx(1, "sk_X509_push");
}
assert(sk_X509_num(*root) == 1);
}
/*
* Add the CRL based on the certs SKI value.
* No need to insert any other CRL since those were already checked.
*/
static void
build_crls(const struct crl *crl, STACK_OF(X509_CRL) **crls)
{
*crls = NULL;
if (crl == NULL)
return;
if ((*crls = sk_X509_CRL_new_null()) == NULL)
errx(1, "sk_X509_CRL_new_null");
if (!sk_X509_CRL_push(*crls, crl->x509_crl))
err(1, "sk_X509_CRL_push");
}
/*
* Validate the X509 certificate. Returns 1 for valid certificates,
* returns 0 if there is a verify error and sets *errstr to the error
* returned by X509_verify_cert_error_string().
*/
int
valid_x509(char *file, X509_STORE_CTX *store_ctx, X509 *x509, struct auth *a,
struct crl *crl, const char **errstr)
{
X509_VERIFY_PARAM *params;
ASN1_OBJECT *cp_oid;
STACK_OF(X509) *intermediates, *root;
STACK_OF(X509_CRL) *crls = NULL;
unsigned long flags;
int error;
*errstr = NULL;
build_chain(a, &intermediates, &root);
build_crls(crl, &crls);
assert(store_ctx != NULL);
assert(x509 != NULL);
if (!X509_STORE_CTX_init(store_ctx, NULL, x509, NULL))
cryptoerrx("X509_STORE_CTX_init");
if ((params = X509_STORE_CTX_get0_param(store_ctx)) == NULL)
cryptoerrx("X509_STORE_CTX_get0_param");
if ((cp_oid = OBJ_dup(certpol_oid)) == NULL)
cryptoerrx("OBJ_dup");
if (!X509_VERIFY_PARAM_add0_policy(params, cp_oid))
cryptoerrx("X509_VERIFY_PARAM_add0_policy");
X509_VERIFY_PARAM_set_time(params, evaluation_time);
flags = X509_V_FLAG_CRL_CHECK;
flags |= X509_V_FLAG_PARTIAL_CHAIN;
flags |= X509_V_FLAG_POLICY_CHECK;
flags |= X509_V_FLAG_EXPLICIT_POLICY;
flags |= X509_V_FLAG_INHIBIT_MAP;
X509_STORE_CTX_set_flags(store_ctx, flags);
X509_STORE_CTX_set_depth(store_ctx, MAX_CERT_DEPTH);
/*
* See the comment above build_chain() for details on what's happening
* here. The nomenclature in this API is dubious and poorly documented.
*/
X509_STORE_CTX_set0_untrusted(store_ctx, intermediates);
X509_STORE_CTX_set0_trusted_stack(store_ctx, root);
X509_STORE_CTX_set0_crls(store_ctx, crls);
if (X509_verify_cert(store_ctx) <= 0) {
error = X509_STORE_CTX_get_error(store_ctx);
*errstr = X509_verify_cert_error_string(error);
X509_STORE_CTX_cleanup(store_ctx);
sk_X509_free(intermediates);
sk_X509_free(root);
sk_X509_CRL_free(crls);
return 0;
}
X509_STORE_CTX_cleanup(store_ctx);
sk_X509_free(intermediates);
sk_X509_free(root);
sk_X509_CRL_free(crls);
return 1;
}
/*
* Validate our RSC: check that all items in the ResourceBlock are contained.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_rsc(const char *fn, struct cert *cert, struct rsc *rsc)
{
size_t i;
uint32_t min, max;
char buf1[64], buf2[64];
for (i = 0; i < rsc->asz; i++) {
min = rsc->as[i].type == CERT_AS_RANGE ? rsc->as[i].range.min
: rsc->as[i].id;
max = rsc->as[i].type == CERT_AS_RANGE ? rsc->as[i].range.max
: rsc->as[i].id;
if (as_check_covered(min, max, cert->as, cert->asz) > 0)
continue;
switch (rsc->as[i].type) {
case CERT_AS_ID:
warnx("%s: RSC resourceBlock: uncovered AS Identifier: "
"%u", fn, rsc->as[i].id);
break;
case CERT_AS_RANGE:
warnx("%s: RSC resourceBlock: uncovered AS Range: "
"%u--%u", fn, min, max);
break;
default:
break;
}
return 0;
}
for (i = 0; i < rsc->ipsz; i++) {
if (ip_addr_check_covered(rsc->ips[i].afi, rsc->ips[i].min,
rsc->ips[i].max, cert->ips, cert->ipsz) > 0)
continue;
switch (rsc->ips[i].type) {
case CERT_IP_RANGE:
ip_addr_print(&rsc->ips[i].range.min,
rsc->ips[i].afi, buf1, sizeof(buf1));
ip_addr_print(&rsc->ips[i].range.max,
rsc->ips[i].afi, buf2, sizeof(buf2));
warnx("%s: RSC ResourceBlock: uncovered IP Range: "
"%s--%s", fn, buf1, buf2);
break;
case CERT_IP_ADDR:
ip_addr_print(&rsc->ips[i].ip,
rsc->ips[i].afi, buf1, sizeof(buf1));
warnx("%s: RSC ResourceBlock: uncovered IP: "
"%s", fn, buf1);
break;
default:
break;
}
return 0;
}
return 1;
}
int
valid_econtent_version(const char *fn, const ASN1_INTEGER *aint)
{
uint64_t version;
if (aint == NULL)
return 1;
if (!ASN1_INTEGER_get_uint64(&version, aint)) {
warnx("%s: ASN1_INTEGER_get_uint64 failed", fn);
return 0;
}
switch (version) {
case 0:
warnx("%s: incorrect encoding for version 0", fn);
return 0;
default:
warnx("%s: version %llu not supported (yet)", fn,
(unsigned long long)version);
return 0;
}
}
/*
* Validate the ASPA: check that the customerASID is contained.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_aspa(const char *fn, struct cert *cert, struct aspa *aspa)
{
if (as_check_covered(aspa->custasid, aspa->custasid,
cert->as, cert->asz) > 0)
return 1;
warnx("%s: ASPA: uncovered Customer ASID: %u", fn, aspa->custasid);
return 0;
}
/*
* Validate Geofeed prefixes: check that the prefixes are contained.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_geofeed(const char *fn, struct cert *cert, struct geofeed *g)
{
size_t i;
char buf[64];
for (i = 0; i < g->geoipsz; i++) {
if (ip_addr_check_covered(g->geoips[i].ip->afi,
g->geoips[i].ip->min, g->geoips[i].ip->max, cert->ips,
cert->ipsz) > 0)
continue;
ip_addr_print(&g->geoips[i].ip->ip, g->geoips[i].ip->afi, buf,
sizeof(buf));
warnx("%s: Geofeed: uncovered IP: %s", fn, buf);
return 0;
}
return 1;
}
/*
* Validate whether a given string is a valid UUID.
* Returns 1 if valid, 0 otherwise.
*/
int
valid_uuid(const char *s)
{
int n = 0;
while (1) {
switch (n) {
case 8:
case 13:
case 18:
case 23:
if (s[n] != '-')
return 0;
break;
/* Check UUID is version 4 */
case 14:
if (s[n] != '4')
return 0;
break;
/* Check UUID variant is 1 */
case 19:
if (s[n] != '8' && s[n] != '9' && s[n] != 'a' &&
s[n] != 'A' && s[n] != 'b' && s[n] != 'B')
return 0;
break;
case 36:
return s[n] == '\0';
default:
if (!isxdigit((unsigned char)s[n]))
return 0;
break;
}
n++;
}
}
int
valid_ca_pkey(const char *fn, EVP_PKEY *pkey)
{
RSA *rsa;
const BIGNUM *rsa_e;
int key_bits;
if (pkey == NULL) {
warnx("%s: failure, pkey is NULL", fn);
return 0;
}
if (EVP_PKEY_base_id(pkey) != EVP_PKEY_RSA) {
warnx("%s: Expected EVP_PKEY_RSA, got %d", fn,
EVP_PKEY_base_id(pkey));
return 0;
}
if ((key_bits = EVP_PKEY_bits(pkey)) != 2048) {
warnx("%s: RFC 7935: expected 2048-bit modulus, got %d bits",
fn, key_bits);
return 0;
}
if ((rsa = EVP_PKEY_get0_RSA(pkey)) == NULL) {
warnx("%s: failed to extract RSA public key", fn);
return 0;
}
if ((rsa_e = RSA_get0_e(rsa)) == NULL) {
warnx("%s: failed to get RSA exponent", fn);
return 0;
}
if (!BN_is_word(rsa_e, 65537)) {
warnx("%s: incorrect exponent (e) in RSA public key", fn);
return 0;
}
return 1;
}
|