diff options
| author | Matthieu Herrb <matthieu@cvs.openbsd.org> | 2016-10-23 11:30:04 +0000 |
|---|---|---|
| committer | Matthieu Herrb <matthieu@cvs.openbsd.org> | 2016-10-23 11:30:04 +0000 |
| commit | 78b7d51db60a07956f2e2505d8aa99b30a8b0d54 (patch) | |
| tree | 4b27c2979c92cf88f0d7db82aecb1ff28924078d | |
| parent | 9c5ff5050b715199b96727b189424e4691de1b48 (diff) | |
greet->password is wiped after handling it to auth_setdata().
No need to wipe again it later.
| -rw-r--r-- | app/xenodm/greeter/verify.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/app/xenodm/greeter/verify.c b/app/xenodm/greeter/verify.c index 240ef31c8..58e765b5a 100644 --- a/app/xenodm/greeter/verify.c +++ b/app/xenodm/greeter/verify.c @@ -139,7 +139,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) if ((authok & AUTH_ALLOW) == 0) { Debug("password verify failed\n"); - bzero(greet->password, passwd_len); auth_close(as); login_close(lc); return 0; @@ -147,7 +146,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) /* Run the approval script */ if (!auth_approval(as, lc, greet->name, "auth-xdm")) { Debug("login not approved\n"); - bzero(greet->password, passwd_len); auth_close(as); login_close(lc); return 0; @@ -162,7 +160,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) /* Only accept root logins if allowRootLogin resource is set */ if (p->pw_uid == 0 && !greet->allow_root_login) { Debug("root logins not allowed\n"); - bzero(greet->password, passwd_len); return 0; } @@ -175,7 +172,6 @@ Verify (struct display *d, struct greet_info *greet, struct verify_info *verify) /* did not found the shell in /etc/shells -> failure */ Debug("shell not in /etc/shells\n"); - bzero(greet->password, passwd_len); endusershell(); return 0; } |