1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
|
commit 8ea4c3e22a2ff79d373f8a364309c5a4a0c01ced
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Oct 12 11:04:07 2024 -0700
xkbprint 1.0.7
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 3ce73201e3d808e5e4f6c20e22d6e6e86e3b81e8
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 28 16:53:26 2024 -0700
Use C99 struct initializers
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xkbprint/-/merge_requests/6>
commit 4868f37f09843432b261371875b2f433f2a1f7fa
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 28 16:38:24 2024 -0700
Variable scope reductions
Some recommended by cppcheck, others found by manual inspection
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xkbprint/-/merge_requests/6>
commit 823cecf574645cd26ed43b18c9c68a06dc25f95a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 28 16:20:59 2024 -0700
FindKeysymsByName: avoid NULL pointer dereference
Clears warning from cppcheck:
psgeom.c:1645:15: warning: Either the condition 'state->args!=0L' is
redundant or there is possible null pointer dereference: state->args.
[nullPointerRedundantCheck]
if ((state->args->wantDiffs) && (eG >= XkbKeyNumGroups(xkb, kc)))
^
psgeom.c:1635:21: note: Assuming that condition 'state->args!=0L' is not
redundant
if (state->args != NULL) {
^
psgeom.c:1645:15: note: Null pointer dereference
if ((state->args->wantDiffs) && (eG >= XkbKeyNumGroups(xkb, kc)))
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xkbprint/-/merge_requests/6>
commit ed190ca257c808b5d76babf01a5dd57c7d749c9d
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 28 16:18:02 2024 -0700
ClearFontStuff: avoid NULL pointer dereference
Clears warning from cppcheck:
psgeom.c:400:5: warning: Either the condition 'stuff' is redundant or there
is possible null pointer dereference: stuff. [nullPointerRedundantCheck]
bzero(stuff, sizeof(FontStuff));
^
psgeom.c:398:9: note: Assuming that condition 'stuff' is not redundant
if (stuff && stuff->foundry)
^
psgeom.c:400:5: note: Null pointer dereference
bzero(stuff, sizeof(FontStuff));
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xkbprint/-/merge_requests/6>
commit 75a78342999f5c98ba5e0d154a1c506497daac5d
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Jul 28 16:13:11 2024 -0700
configure: Use AC_SYS_LARGEFILE to enable large file support
While keymap files or generated output should never be more than 2gb in
size, they may be stored on filesystems with inodes or timestamps outside
of the 32-bit range.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/app/xkbprint/-/merge_requests/6>
commit 1a4c0388e5a8c938544e0e6c5ccdb92a51de1b84
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Feb 11 12:31:51 2023 -0800
unifdef -Usgi
SGI's End of Support Life for Irix was December 2013
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7500b59a3ce665fa53c476fe26a01db96dc994be
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Oct 15 10:26:33 2022 -0700
xkbprint 1.0.6
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 69deaf13057d3a8b9c01350e2cdfc40080f5433a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Apr 16 11:56:06 2022 -0700
gitlab CI: stop requiring Signed-off-by in commits
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f586ae4a0a8d081c46f10f4cb4c27840d611edec
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Apr 16 11:51:37 2022 -0700
Stop leaking XkbAtomGetString allocations
XkbAtomGetString is a wrapper around XGetAtomName, and like XGetAtomName
returns a newly allocated string (or NULL) on every call, so we should
free those strings when done instead of leaking them.
Reported by Oracle Parfait static analyser:
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(state->dpy, state->geom->name)
at line 720 of app/xkbprint/psgeom.c in function 'PSProlog'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 612 of app/xkbprint/psgeom.c in function 'PSProlog' with XkbAtomGetString(state->dpy, state->geom->name)
pointer leaks when (i + 1) >= state->geom->num_colors at line 694
and (i + 1) >= state->geom->num_shapes at line 712.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(state->dpy, state->geom->name)
at line 720 of app/xkbprint/psgeom.c in function 'PSProlog'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 657 of app/xkbprint/psgeom.c in function 'PSProlog' with XkbAtomGetString(state->dpy, state->geom->name)
pointer leaks when (i + 1) >= state->geom->num_colors at line 694
and (i + 1) >= state->geom->num_shapes at line 712.
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer name allocated with XkbAtomGetString(state->dpy, geom->name)
at line 962 of app/xkbprint/psgeom.c in function 'PSPageTrailer'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
name allocated at line 845 of app/xkbprint/psgeom.c in function 'PSPageTrailer' with XkbAtomGetString(state->dpy, geom->name)
name leaks when (p + 1) >= state->args->copies at line 926.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer sName allocated with XkbAtomGetString(state->dpy, sAtom)
at line 962 of app/xkbprint/psgeom.c in function 'PSPageTrailer'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
sName allocated at line 877 of app/xkbprint/psgeom.c in function 'PSPageTrailer' with XkbAtomGetString(state->dpy, sAtom)
sName leaks when (p + 1) >= state->args->copies at line 926.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer sName allocated with XkbAtomGetString(state->dpy, sAtom)
at line 962 of app/xkbprint/psgeom.c in function 'PSPageTrailer'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
sName allocated at line 910 of app/xkbprint/psgeom.c in function 'PSPageTrailer' with XkbAtomGetString(state->dpy, sAtom)
sName leaks when (p + 1) >= state->args->copies at line 926.
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer dname allocated with XkbAtomGetString(xkb->dpy, doodad.any.name)
at line 1068 of app/xkbprint/psgeom.c in function 'PSDoodad'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
dname allocated at line 974 of app/xkbprint/psgeom.c in function 'PSDoodad' with XkbAtomGetString(xkb->dpy, doodad.any.name)
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer name allocated with XkbAtomGetString(...)
at line 1068 of app/xkbprint/psgeom.c in function 'PSDoodad'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
name allocated at line 980 of app/xkbprint/psgeom.c in function 'PSDoodad' with XkbAtomGetString(...)
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer name allocated with XkbAtomGetString(...)
at line 1068 of app/xkbprint/psgeom.c in function 'PSDoodad'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
name allocated at line 1044 of app/xkbprint/psgeom.c in function 'PSDoodad' with XkbAtomGetString(...)
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer name allocated with XkbAtomGetString(...)
at line 1068 of app/xkbprint/psgeom.c in function 'PSDoodad'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
name allocated at line 1058 of app/xkbprint/psgeom.c in function 'PSDoodad' with XkbAtomGetString(...)
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(dpy, section->name)
at line 2063 of app/xkbprint/psgeom.c in function 'PSSection'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 1907 of app/xkbprint/psgeom.c in function 'PSSection' with XkbAtomGetString(dpy, section->name)
pointer leaks when (k + 1) >= (section->rows + <pointer arithmetic>)->num_keys at line 1936
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(dpy, shape->name)
at line 2063 of app/xkbprint/psgeom.c in function 'PSSection'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 1945 of app/xkbprint/psgeom.c in function 'PSSection' with XkbAtomGetString(dpy, shape->name)
pointer leaks when (k + 1) >= (section->rows + <pointer arithmetic>)->num_keys at line 1936
and (r + 1) >= section->num_rows at line 1925.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(dpy, shape->name)
at line 2063 of app/xkbprint/psgeom.c in function 'PSSection'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 1951 of app/xkbprint/psgeom.c in function 'PSSection' with XkbAtomGetString(dpy, shape->name)
pointer leaks when (k + 1) >= (section->rows + <pointer arithmetic>)->num_keys at line 1936
and (r + 1) >= section->num_rows at line 1925.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(dpy, shape->name)
at line 2063 of app/xkbprint/psgeom.c in function 'PSSection'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 1960 of app/xkbprint/psgeom.c in function 'PSSection' with XkbAtomGetString(dpy, shape->name)
pointer leaks when (k + 1) >= (section->rows + <pointer arithmetic>)->num_keys at line 1936
and (r + 1) >= section->num_rows at line 1925.
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer pointer allocated with XkbAtomGetString(dpy, shape->name)
at line 2063 of app/xkbprint/psgeom.c in function 'PSSection'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
pointer allocated at line 1966 of app/xkbprint/psgeom.c in function 'PSSection' with XkbAtomGetString(dpy, shape->name)
pointer leaks when (k + 1) >= (section->rows + <pointer arithmetic>)->num_keys at line 1936
and (r + 1) >= section->num_rows at line 1925.
Error: Memory leak
Memory leak [memory-leak] (CWE 401):
Memory leak of pointer name allocated with XkbAtomGetString(...)
at line 2131 of app/xkbprint/psgeom.c in function 'GeometryToPostScript'.
Allocated value returned to caller at line 207 of lib/libxkbfile/src/xkbatom.c in function 'XkbAtomGetString'
name allocated at line 2110 of app/xkbprint/psgeom.c in function 'GeometryToPostScript' with XkbAtomGetString(...)
name leaks when name != NULL at line 2111.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit cc85e7b233613633a5496f0fa27bf49b409c33e4
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat Apr 2 12:57:58 2022 -0700
man page: remove out-of-date COPYRIGHT section
The information previously listed here didn't match what is present in
the source code or the COPYING file, and the X(7) man page doesn't list
any license information as this had claimed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit df4b45b62fafb218b613baade4a831522effdfcc
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon Dec 6 15:01:12 2021 -0800
Build xz tarballs instead of bzip2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 963fd74b2c425e700e9a15942963fd78c9dcd447
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon Dec 6 15:01:09 2021 -0800
gitlab CI: add a basic build test
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7defa9ddfd5f5d1853b9f404af854b0f42fa6ee5
Author: Matt Turner <mattst88@gmail.com>
Date: Sun Nov 3 14:20:07 2019 -0800
xkbprint 1.0.5
Signed-off-by: Matt Turner <mattst88@gmail.com>
commit b968db6ca6fdb6ebb2384eaffaabe406c5cf783f
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sun Sep 15 17:53:55 2019 -0700
xkbprint(1): Some (typographical) corrections to the manual
Fixes: https://gitlab.freedesktop.org/xorg/app/xkbprint/issues/2
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742356
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 9b134b4835cc0b6743bbd67d61b647dff3941ca9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Wed Nov 21 17:12:07 2018 -0800
Update configure.ac bug URL for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit d15a9ce43042d12c545d194f46075214678046e9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Fri Nov 16 22:27:40 2018 -0800
Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 8122e255d9c8c417d1eb9496b9b7b5c6cb53c334
Author: Mihail Konev <k.mvc@ya.ru>
Date: Thu Jan 26 14:00:21 2017 +1000
autogen: add default patch prefix
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
commit e43f3641499669bc993fe8370b58dac94d4e7eb1
Author: Emil Velikov <emil.l.velikov@gmail.com>
Date: Mon Mar 9 12:00:52 2015 +0000
autogen.sh: use quoted string variables
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
commit b08a9ce8e834d5c019b37a63dbc2e06b2ace93ca
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date: Tue Jan 24 10:32:07 2017 +1000
autogen.sh: use exec instead of waiting for configure to finish
Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
commit facf56074567094349d9050e99a659d8e3a1b0ce
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Thu Apr 16 23:41:38 2015 -0700
xkbprint 1.0.4
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit e4c1258143bf09de5453faafe2c6f0bc107a1523
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 21:39:32 2014 -0700
autogen.sh: Honor NOCONFIGURE=1
See http://people.gnome.org/~walters/docs/build-api.txt
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 4b12d476447952ab0a5a7a30d35d43de6f7418f8
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 21:38:41 2014 -0700
configure: Drop AM_MAINTAINER_MODE
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 59d82dc7c5dd4a6ca2098ba51fb9683fb03720ab
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 21:33:34 2014 -0700
Remove old CVS id tags
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 545db04829433b7d30de75ea03dc4495a91a8ab6
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 20:16:42 2014 -0700
Add -version option to print program version
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 8e86b50311c3b926d2bb1e00fb5343f3e76d55b3
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 19:51:00 2014 -0700
Fix some sign/size conversion warnings from clang
psgeom.c:1320:17: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
if ((sym & (~0xff)) == 0x700) {
~ ^~~~~
psgeom.c:1666:31: warning: implicit conversion changes signedness:
'int' to 'unsigned long' [-Wsign-conversion]
else if (((sym & (~0xff)) == 0) && isprint(sym) && (!isspace(sym))) {
~ ^~~~~
psgeom.c:1860:27: warning: implicit conversion loses integer precision:
'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
int len = strlen(top->label[i]);
~~~ ^~~~~~~~~~~~~~~~~~~~~
xkbprint.c:460:19: warning: implicit conversion loses integer precision:
'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
int len = strlen(inputFile);
~~~ ^~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 641a71f594688d870540be47ddff339d746a4fa0
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 19:40:34 2014 -0700
Remove unused INPUT_* definitions
Flagged by clang:
xkbprint.c:62:9: warning: macro is not used [-Wunused-macros]
^
xkbprint.c:61:9: warning: macro is not used [-Wunused-macros]
^
xkbprint.c:60:9: warning: macro is not used [-Wunused-macros]
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 4bbc62129724cdc61f601e4f1c98490bca403619
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 19:18:08 2014 -0700
Move some local variables to the scope in which they live
Helps both human readers and static code analyzers realize they're not
used outside these scopes.
Flagged by cppcheck 1.64:
[psgeom.c:1761]: (style) The scope of the variable 'keycode' can be reduced.
[psgeom.c:1858]: (style) The scope of the variable 'len' can be reduced.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7d186165440c5a370af7551f5958baae2f0b3725
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Sat May 31 19:00:09 2014 -0700
Combine IsoKeyCaps array of strings into a single string
Packs more efficiently in binary, reduces number of calls to output,
gets rid of ~4k array of pointers to each string in data segment to
initialize on program load.
"xkbprint -if IsoKeyCaps" generates identical IsoKeyCaps.pfa files
before & after this change.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit bac53a94fec22563294cb57413e8d394df06c70a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 21:51:01 2014 -0700
Replace calls to index() with calls to strchr()
Both were in use in different functions, adopt the ANSI C standard
function for all calls.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 5ee01f266fd315e5bee624ec9d54357ffa593dfc
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 21:50:29 2014 -0700
Combine repeated sequences of fprintf() calls into single calls
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit e7aa5ea85d57b90c1ee3244facd2dfd4d3ff1cd5
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 21:04:05 2014 -0700
Replace remaining sprintf calls with snprintf()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit bfb6044479e8e974e848f47969f75b84865fea13
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 20:55:33 2014 -0700
Replace several malloc+sprintf pairs with asprintf() calls
Includes fallback uAsprintf() for systems without asprintf yet
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7848ba1d292f55553058c1f17596baa1094cdae5
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 20:39:48 2014 -0700
Add printf & noreturn attributes recommended by gcc
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 8a7b707f6f841655498c753701ee38f12ba630cf
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 20:35:49 2014 -0700
Replace uStrCaseCmp() with direct calls to strcasecmp()
strcasecmp is available in Unix98 and later, so part of the X.Org base
platform requirements.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit e144ec9018cabd1d9904fb6d04382d2cf06ec3dc
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 20:32:42 2014 -0700
Replace uStringDup() with direct calls to strdup()
strdup is available in Unix98 and later, so part of the X.Org base
platform requirements.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit cefec39d93846c2d034be9a89f48466831eddde6
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Tue May 27 20:30:20 2014 -0700
Replace custom uAlloc/uCalloc with plain malloc/calloc
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit ab92831be0e862622105f015fe8c390715d2aae9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:15:00 2014 -0700
Replace sole call to uFree() with direct call to free()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 4ae1b3d5f5330a8f7bd8880860a204000081095c
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:13:23 2014 -0700
Remove unused uTmpAlloc & uTmpFree fallbacks for alloca
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit e9a66d6ba4d0edd2d2d12cd0271aaecc43b6067d
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:12:05 2014 -0700
Remove unused uRealloc & uRecalloc functions
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit dbbc677985e3a853f2e52b8a9d09660d3fa6d983
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:10:33 2014 -0700
Remove unused uStrCasePrefix fallback for strncasecmp
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7ca2572623fee8db916eff668ef3c852f2ce124a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:09:29 2014 -0700
Remove unused debugging & function tracing frameworks
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit b883af48e9624e2215d1e790ca0da4969480ce13
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:06:05 2014 -0700
Remove unused uASSERT macro
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 5256304812e89c1c02bed093d11f96d97216bdbe
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 16:03:30 2014 -0700
Fix many const char * warnings
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit e1b1ecd2e9858dca67ed1da90799f1ea34fc9b71
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 10:17:12 2014 -0700
unifdef -Unotyet -UNOTYET
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 9456437718d78b942333bdf74124c027ba35039f
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Mon May 26 10:13:31 2014 -0700
Convert sources to X.Org standard coding style
Via util/modular/x-indent-all.sh
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 7ebdc6c2ed2917dd48687aa16c6909186a575e2d
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Wed Jan 19 10:06:56 2011 -0500
config: move man pages into their own directory
Use services provided by XORG_MANPAGE_SECTIONS.
Use standard Makefile for man pages.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
commit d762e97a2c6745017912b19fe443ed814d557a51
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Thu Jan 13 17:15:36 2011 -0500
man: replace hard coded man page section with substitution strings
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
commit a65ad77d80a1037889d4ba8aa061d109a0d15c2c
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Thu Jan 13 11:15:47 2011 -0500
man: remove trailing spaces and tabs
Using s/[ \t]*$//
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
commit 93479193971679781c302dcfda3f653ea67fb452
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Fri Jan 7 19:09:37 2011 -0800
xkbprint 1.0.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit c6cb1b17600e2c2937751a712c7eadd411eb6da9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Wed Jan 5 17:03:30 2011 -0800
config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS
Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Add missing AC_CONFIG_SRCDIR
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 5d321bc363ce5ef67a1297e24ed184a28eed4e9d
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Wed Jan 5 17:00:42 2011 -0800
config: upgrade to util-macros 1.8 for additional man page support
Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.
Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
Enables use of platform appropriate version of sed.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 16c0b77e78ce2ce750b690469850294f5e69ab97
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Wed Jan 5 16:58:47 2011 -0800
config: update AC_PREREQ statement to 2.60
Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.
ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gz
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit 6b8537579db562937af77ca5a4b0e19893a7bbee
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date: Wed Jan 5 16:58:25 2011 -0800
config: Remove unnecessary calls from configure.ac
AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
commit f15a69148c2ed5cf1717a0ad942ecdfcf037104d
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Thu Nov 26 09:19:54 2009 -0500
Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES
Now that the INSTALL file is generated.
Allows running make maintainer-clean.
commit 90d54a9a94ac30ac6ee7fa78ea8e6a898490afe6
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Wed Oct 28 14:09:08 2009 -0400
INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206
Add missing INSTALL file. Use standard GNU file on building tarball
README may have been updated
Remove AUTHORS file as it is empty and no content available yet.
Remove NEWS file as it is empty and no content available yet.
commit 8d49899afe456a93c2bb7477b963fd31dbad5942
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Tue Oct 27 15:07:25 2009 -0400
Deploy the new XORG_DEFAULT_OPTIONS #24242
This macro aggregate a number of existing macros that sets commmon
X.Org components configuration options. It shields the configuration file from
future changes.
commit d2d7a487230ebc281aa2d1a88038befb69e63b7d
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Mon Oct 26 22:08:39 2009 -0400
Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432
ChangeLog filename is known to Automake and requires no further
coding in the makefile.
commit 2683cf26ec97c49fac6145227d9f4cae3fa8a1bd
Author: Gaetan Nadon <memsize@videotron.ca>
Date: Thu Oct 22 12:34:15 2009 -0400
.gitignore: use common defaults with custom section # 24239
Using common defaults will reduce errors and maintenance.
Only the very small or inexistent custom section need periodic maintenance
when the structure of the component changes. Do not edit defaults.
commit 31b7584cd60accc2d7dbaf5797d34495e321b793
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date: Tue Nov 10 23:39:43 2009 -0800
xkbprint 1.0.2
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
commit ec17f1a60b1c9d9871213eae475740640fe6312d
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date: Tue Nov 10 23:38:29 2009 -0800
Fill in COPYING with notices from code
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
commit 4ecf1e50d97afde8c5e343d6c25e5a1eb940e02c
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date: Tue Nov 10 23:34:48 2009 -0800
Migrate to xorg macros 1.3 & XORG_DEFAULT_OPTIONS
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
commit bcf318755e452925e6cc06ea564f63e846cabf38
Author: Alan Coopersmith <alan.coopersmith@sun.com>
Date: Thu Oct 1 14:54:25 2009 -0700
Add README with pointers to mailing lists, bugzilla, & git
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
commit d67733133b7a1062628e6c5e7512adf998026b6a
Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
Date: Thu Jan 22 14:53:41 2009 -0200
Correct make distcheck and sparse warnings.
commit 077871dce17f78ffa94e8bc2de21461fd8a4960d
Author: Peter Breitenlohner <peb@mppmu.mpg.de>
Date: Fri Nov 14 13:37:05 2008 +0100
build fixes
use AM_CFLAGS instead of xkbprint_CFLAGS to avoid need for AM_PROG_CC_C_O
replace 'git-log' by 'git log' as required by git-1.6.x
commit 58d940fbb303cc16549f913e33429362760132de
Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
Date: Sun Mar 16 19:02:31 2008 -0300
Compile warning fixes.
Use constant octals instead of constant characters in switch case values
to avoid warnings/problems if constant characters are signed.
Ansify some functions in utils.c.
Signed-off-by: Peter Breitenlohner <peb@mppmu.mpg.de>
commit 885f2712b0d5137d5349c3debbcea0db0f39e92f
Author: Pavel Kurashov <pavell@mail.ru>
Date: Fri Nov 14 13:50:20 2008 +0100
correct outline with cornerRadius
http://bugs.freedesktop.org/show_bug.cgi?id=12790
https://bugs.freedesktop.org/attachment.cgi?id=12008
Signed-off-by: Peter Breitenlohner <peb@mppmu.mpg.de>
commit 6bd5defc38d2e1868d9303026b38487d6bffc7ab
Author: Niveditha Rau <Niveditha.Rau@Sun.COM>
Date: Thu Jun 12 16:52:05 2008 -0700
Fix typo in xkbprint man page
commit 6e1a5562d22f2f7cdc9478be1e3c809dfa509573
Author: James Cloos <cloos@jhcloos.com>
Date: Thu Dec 6 16:37:19 2007 -0500
Replace static ChangeLog with dist-hook to generate from git log
commit a912837d96da29022c0a2a75212ac381aec1dcfe
Author: James Cloos <cloos@jhcloos.com>
Date: Mon Sep 3 05:51:27 2007 -0400
Add *~ to .gitignore to skip patch/emacs droppings
commit 4063d540920f603f334dc3bb8f478db23cdaa9e0
Author: James Cloos <cloos@jhcloos.com>
Date: Thu Aug 23 19:24:53 2007 -0400
Rename .cvsignore to .gitignore
commit 696b7234c93e3e9a6b8302640e625868699567ab
Author: Kevin E Martin <kem@kem.org>
Date: Wed Dec 21 02:29:51 2005 +0000
Update package version for X11R7 release.
commit 5e62ccda04eb02c3db07896a34253211ae749581
Author: Adam Jackson <ajax@nwnk.net>
Date: Mon Dec 19 16:22:45 2005 +0000
Stub COPYING files
commit e0e4e20547bf3f04f683e318862290b3fbaa0b37
Author: Kevin E Martin <kem@kem.org>
Date: Thu Dec 15 00:24:08 2005 +0000
Update package version number for final X11R7 release candidate.
commit 0a4cd3760ebc41fa95fea45ba0cc5579beebba4a
Author: Kevin E Martin <kem@kem.org>
Date: Tue Dec 6 22:48:23 2005 +0000
Change *man_SOURCES ==> *man_PRE to fix autotools warnings.
commit f64993bf8cc357a05ee11ce28e0c60322cec98d2
Author: Kevin E Martin <kem@kem.org>
Date: Sat Dec 3 05:49:24 2005 +0000
Update package version number for X11R7 RC3 release.
commit 6dbafe93cd59e599bebf5d0fae7ecb87a42da8e1
Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
Date: Mon Nov 28 22:01:43 2005 +0000
Change *mandir targets to use new *_MAN_DIR variables set by xorg-macros.m4
update to fix bug #5167 (Linux prefers *.1x man pages in man1 subdir)
commit a7fca74540833d1d1cf02e6455cd33a91951e6e1
Author: Eric Anholt <anholt@freebsd.org>
Date: Mon Nov 21 10:35:02 2005 +0000
Another pass at .cvsignores for apps.
commit 1c9055c2dbdb68f1f419ffac0596130c3bda61e8
Author: Eric Anholt <anholt@freebsd.org>
Date: Sun Nov 20 22:08:53 2005 +0000
Add/improve .cvsignore files for apps.
commit 1739444b40ef1e07e9bd6e0d9fe1f1e6e254809a
Author: Kevin E Martin <kem@kem.org>
Date: Sat Nov 19 07:15:37 2005 +0000
Update pkgconfig files to separate library build-time dependencies from
application build-time dependencies, and update package deps to work
with separate build roots.
commit 3eb0b0085955c8213c869a8b14e8ec00f3514b7b
Author: Kevin E Martin <kem@kem.org>
Date: Wed Oct 19 02:47:55 2005 +0000
Update package version number for RC1 release.
commit a59499ec60ad710155a8ff27158945551270d6b8
Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
Date: Mon Oct 17 23:56:23 2005 +0000
Use @APP_MAN_SUFFIX@ instead of $(APP_MAN_SUFFIX) in macro substitutions to
work better with BSD make
commit 3e3050ac678f225dfd9a2f50778b603a3e7f5da4
Author: Alan Coopersmith <Alan.Coopersmith@sun.com>
Date: Fri Oct 14 00:25:46 2005 +0000
Use sed to fill in variables in man page
commit a3be5e6602ee8614401d62d8b37ae0f2bed0f631
Author: Kevin E Martin <kem@kem.org>
Date: Fri Jul 29 21:22:35 2005 +0000
Various changes preparing packages for RC0:
- Verify and update package version numbers as needed
- Implement versioning scheme
- Change bug address to point to bugzilla bug entry form
- Disable loadable i18n in libX11 by default (use --enable-loadable-i18n to
reenable it)
- Fix makedepend to use pkgconfig and pass distcheck
- Update build script to build macros first
- Update modular Xorg version
commit 10e946b8da2718e6657e8a1a880fd46acc6c5ce8
Author: Daniel Stone <daniel@fooishbar.org>
Date: Wed Jul 27 01:54:18 2005 +0000
Move manpages to section 1 instead of section m.
commit 95191a911fce864af7349df2377363885e4c920f
Author: Adam Jackson <ajax@nwnk.net>
Date: Wed Jul 20 19:31:57 2005 +0000
Use a unique token for PKG_CHECK_MODULES. Otherwise, if you use a global
configure cache, you cache it, and the cached value is probably wrong.
commit c4b22b69df1162dab5db3691053ac0b6fb4c4503
Author: Søren Sandmann Pedersen <sandmann@daimi.au.dk>
Date: Wed Jul 6 20:42:02 2005 +0000
Build system for xkbprint
commit 15c4274c3da2c63bd83b14ef4d35727222d62ed2
Author: Egbert Eich <eich@suse.de>
Date: Fri Apr 23 19:54:57 2004 +0000
Merging XORG-CURRENT into trunk
commit e4848d45534f7ff28304397ca9ff0aa2de6cfe97
Author: Egbert Eich <eich@suse.de>
Date: Sun Mar 14 08:35:37 2004 +0000
Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004
commit ca0576c0a0b21eb60562995318594a2958a76e9d
Author: Egbert Eich <eich@suse.de>
Date: Wed Mar 3 12:13:14 2004 +0000
Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004
commit 31c64747c1c70a36a916921519d004f22263964f
Author: Egbert Eich <eich@suse.de>
Date: Thu Feb 26 13:36:26 2004 +0000
readding XFree86's cvs IDs
commit 17de96585abae92ffab5e61b9890fb3170c202cd
Author: Egbert Eich <eich@suse.de>
Date: Thu Feb 26 09:24:13 2004 +0000
Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004
commit 53c425e61c058fa586040dda56728906025989e8
Author: Kaleb Keithley <kaleb@freedesktop.org>
Date: Tue Nov 25 19:29:14 2003 +0000
XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folks
commit 1952210eda8c22ca34704894290e9a39ee96ecb4
Author: Kaleb Keithley <kaleb@freedesktop.org>
Date: Fri Nov 14 16:49:23 2003 +0000
XFree86 4.3.0.1
commit e621300441be997039c5f1abadd92fc3bab733f8
Author: Kaleb Keithley <kaleb@freedesktop.org>
Date: Fri Nov 14 15:54:54 2003 +0000
R6.6 is the Xorg base-line
|